Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0API]support set_default_dtype for to_tensor #26432

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Aug 19, 2020

PR types

Bug fixes

PR changes

APIs

Describe

support set_default_dtype for to_tensor.

related with #26006

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhwesky2010 zhwesky2010 changed the title support set_default_dtype for to_tensor [2.0API]support set_default_dtype for to_tensor Aug 19, 2020
jzhang533
jzhang533 previously approved these changes Aug 20, 2020
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhwesky2010 zhwesky2010 force-pushed the set_default_type branch 4 times, most recently from ce5c1bd to d3bea04 Compare August 25, 2020 05:27
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Aug 26, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Aug 26, 2020
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Aug 26, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Aug 26, 2020
'complex64' , 'complex128' only for ComplexTensor.
Default: None, infers data type from ``data`` .
'complex64' , 'complex128' only for ComplexTensor.
Default: None, infers type from ``data`` if not ``set_default_type`` .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句话没说清楚啊。
不管有没有调用set_default_type,都是有一个默认数据类型的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -234,6 +234,7 @@
"prroi_pool"
],
"wlist_temp":[
"to_tensor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要加到白名单里。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要加到白名单里。

现在示例代码不能跑GPU的,但这个示例代码要有GPU的,所以只能先加白名单,可以看下示例代码,本地跑了没问题

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
will delete from wlist_temp later

@zhwesky2010 zhwesky2010 merged commit 7b78bfc into PaddlePaddle:develop Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants