-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【paddle.distributed.fleet】add data_generator in distributed.fleet.dataset #27345
【paddle.distributed.fleet】add data_generator in distributed.fleet.dataset #27345
Conversation
Thanks for your contribution! |
@@ -21,7 +21,7 @@ | |||
import random | |||
|
|||
import paddle | |||
import paddle.fluid.incubate.data_generator as data_generator | |||
from paddle.distributed.fleet.dataset import data_generator as data_generator | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move data_generator to paddle.distributed.fleet
… mod_dataset_v2
… mod_dataset_v2
""" | ||
DataGenerator is a general Base class for user to inherit | ||
A user who wants to define his/her own python processing logic | ||
with paddle.fluid.dataset should inherit this class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里还是paddle.fluid.dataset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2020-09-25 11:48:34 ****************
2020-09-25 11:48:34 0. You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for python/paddle/distributed/__init, which manages the underlying code for fluid.
这个文件应该加上 @guru4elephant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR types
Others
PR changes
Others
Describe
add data_generator in paddle.distributed.fleet.dataset to illustrate dataset class well
Based on comments of this pr:#27133 (review)
1, mark static only in new dataset api doc
2, mark deprecated in dataset api in fluid
3, example codes fit with 2.0 apis
my_data_generator class base on class MultiSlotDataGenerator
my_data_generator.py:
paddle.distributed.InMemoryDataset/QueueDataset using data_generator demo