-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine fleet dataset class api #27133
Conversation
Thanks for your contribution! |
@@ -991,6 +908,107 @@ def __init__(self): | |||
self.boxps = core.BoxPS(self.dataset) | |||
self.proto_desc.name = "PaddleBoxDataFeed" | |||
|
|||
def init(self, **kwargs): | |||
""" | |||
should be called only once in user's python scripts to initialize seetings of dataset instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: seetings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"get_world_size", | ||
"prepare_context", | ||
"ParallelEnv", | ||
"init_parallel_env", "get_rank", "get_world_size", "prepare_context", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to keep original layout, and add a comma at the last line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- deprecate apis in
paddle.fluid.dataset
as discussed in move dataset from paddfle.fluid to paddle.fleet #25887 - have some examples to demonstrate working with dygraph mode.
- have some examples to demonstrate working with apis in
paddle.static
- add docs to show typical scenarios of using these apis
- what's the format of files in
set_filelist
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
will have followup prs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit c67c391.
PR types
Others
PR changes
APIs
Describe
1, hide some setting method and other methods in dataset class. These methods will be set at init() once by passing specific key value pair.
2, move some method from base class to child class.
3, modify related ut.
4, update example codes.
dataset api python demo
update according to comments
1, only expose InMemoryDataset and QueueDataset in paddle.distributed, which can be created directly without using factory
2, add init_distributed_settings() method to set advanced distributed related settings.
3, add update_settings() method to update some settings on a existed dataset instance.