Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brpc_ps_client upgrade #36943

Merged
merged 18 commits into from
Nov 12, 2021
Merged

Conversation

zhaocaibei123
Copy link
Contributor

@zhaocaibei123 zhaocaibei123 commented Nov 2, 2021

PR types

Function optimization

PR changes

Others

Describe

upgrade brpc_ps_client
add push_sparse/push_dense function to brpc_ps_client, which is more stable and effective than previous implementation in communicator

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 2, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Sorry to inform you that e05d7df's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for const_cast

@Thunderbrook Thunderbrook merged commit bd79ae8 into PaddlePaddle:develop Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants