Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix boardcasting superlink #48434

Merged
merged 22 commits into from
Dec 2, 2022
Merged

fix boardcasting superlink #48434

merged 22 commits into from
Dec 2, 2022

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Nov 28, 2022

PR types

Others

PR changes

Others

Describe

原 PR 见 #48283

@paddle-bot
Copy link

paddle-bot bot commented Nov 28, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

``paddle.%s`` supports broadcasting. If you want know more about broadcasting, please refer to :ref:`user_guide_broadcasting`.
``paddle.%s`` supports broadcasting. If you want know more about broadcasting, please refer to please refer to `Introduction to Tensor`_ .

.. _Introduction to Tensor: ../../guides/beginner/tensor_en.html#chapter5-broadcasting-of-tensor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!
我在检查文档的过程中发现paddle.bitwise_not在文档中遗漏了broadcasting的说明,辛苦加上~

python/paddle/distribution/uniform.py Outdated Show resolved Hide resolved
``paddle.floor_divide`` supports broadcasting. If you want know more about broadcasting, please refer to :ref:`user_guide_broadcasting` .
``paddle.floor_divide`` supports broadcasting. If you want know more about broadcasting, please refer to `Introduction to Tensor`_ .

.. _Introduction to Tensor: ../../guides/beginner/tensor_en.html#chapter5-broadcasting-of-tensor
Also note that the name ``floor_divide`` can be misleading, as the quotinents are actually rounded toward zero, not toward negative infinite.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

出现了一个报错,需要在链接和 Also note that 之间加个空行

@@ -3962,7 +3982,12 @@ def any(x, axis=None, keepdim=False, name=None):

def broadcast_shape(x_shape, y_shape):
"""
The function returns the shape of doing operation with broadcasting on tensors of x_shape and y_shape, please refer to :ref:`user_guide_broadcasting` for more details.
The function returns the shape of doing operation with broadcasting on tensors of x_shape and y_shape, please refer to boardcasting for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refer to boardcasting for more details. 和下文的note重复了,删掉吧

Ligoml
Ligoml previously approved these changes Nov 30, 2022
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!
LGTM

Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@Ligoml Ligoml merged commit c34812a into PaddlePaddle:develop Dec 2, 2022
lxsbupt pushed a commit to lxsbupt/Paddle that referenced this pull request Dec 17, 2022
* fix boardcasting superlink

* Update bitwise_op.cc

* fix typo errors(from 48186)

* Update python/paddle/distribution/uniform.py

Co-authored-by: Ligoml <39876205+Ligoml@users.noreply.github.com>

* Update math.py

* Update math.py

* refix

* Update logic.py

* BaseTransform api doc; test=docs_preview

* Update python/paddle/vision/transforms/transforms.py

* for text block; test=docs_preview

* Update transforms.py

Co-authored-by: Ligoml <39876205+Ligoml@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants