Add compare accuracy api #53430
Merged
Add compare accuracy api #53430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
zkh2016
force-pushed
the
add_compare_accuracy_api
branch
from
0d1d8ac
to
ad74a83
Compare
zkh2016
force-pushed
the
add_compare_accuracy_api
branch
from
b7ee5a6
to
62debc6
Compare
zkh2016
force-pushed
the
add_compare_accuracy_api
branch
from
77fa114
to
becb1e5
Compare
added 5 commits
May 8, 2023 07:33
AnnaTrainingG
approved these changes
May 9, 2023
zkh2016
force-pushed
the
add_compare_accuracy_api
branch
from
5b56e23
to
369b5e2
Compare
| dump_path(str): The path of the running log, such as the log for execution using the fp32 type. | ||
| another_dump_path(str): the path of another running log ,such as the log for execution using the fp16 type. | ||
| output_filename(str): the excel file nmae of compare output. | ||
| loss_scale(float): the loss_scale during the training phase. |
There was a problem hiding this comment.
- 这个参数好像也是可选的，请确认下，加上optional。
- 写清楚该参数的默认值，以及默认值的含义
| This is a precision comparison tool that can be used to compare log data of float16 and float32. | ||
|
|
||
| Args: | ||
| dump_path(str): The path of the running log, such as the log for execution using the fp32 type. |
There was a problem hiding this comment.
type建议写成 data type，下同
感谢，我再提一个修复的PR |
sunzhongkai588
approved these changes
May 9, 2023
There was a problem hiding this comment.
@zkh2016 LGTM。 该pr先合入，需要在 5月12 日前提供以下优化
- 本pr提及的文档优化建议
- 该api对应的中文文档
lanxianghit
approved these changes
May 9, 2023
zyfncg
approved these changes
May 9, 2023
kolinwei
approved these changes
May 9, 2023
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
新增精度对比接口，解析两个日志或Dump文件里面的数据，并生成excel。
效果：
