Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compare_accuracy #5874

Merged
merged 2 commits into from
May 11, 2023
Merged

add compare_accuracy #5874

merged 2 commits into from
May 11, 2023

Conversation

zkh2016
Copy link
Contributor

@zkh2016 zkh2016 commented May 10, 2023

新增精度比对工具,代码PR:PaddlePaddle/Paddle#53430

@paddle-bot
Copy link

paddle-bot bot commented May 10, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5874.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还需要注意:

- **another_dump_path** (str): 另一份运行日志的路径,比如数据类型是 float16 的训练日志。
- **output_filename** (str): 输出 excel 的文件名,用于保存两份日志的比对结果。
- **loss_scale** (float, 可选): 训练阶段的 loss_scale,默认是 1。
- **dump_all_tensors** (bool, 可选): dump 所有的 tensor 数据,当前还不支持这个参数,默认是 False。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加默认值是 false 代表的含义,如默认是 False,表示...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

:::::::::

COPY-FROM: paddle.amp.debugging.compare_accuracy
~
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是多加了个

@@ -12,7 +12,7 @@ compare_accuracy
- **another_dump_path** (str): 另一份运行日志的路径,比如数据类型是 float16 的训练日志。
- **output_filename** (str): 输出 excel 的文件名,用于保存两份日志的比对结果。
- **loss_scale** (float, 可选): 训练阶段的 loss_scale,默认是 1。
- **dump_all_tensors** (bool, 可选): dump 所有的 tensor 数据,当前还不支持这个参数,默认是 False。
- **dump_all_tensors** (bool, 可选): True表示dump 所有的 tensor 数据,False表示不做处理,当前还不支持这个参数,默认是 False。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中英文需要留空格,否则代码风格检查的ci会不过

改成True 表示 dump 所有的 tensor 数据,False 表示不做处理,当前还不支持这个参数,默认是 False。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkh2016 zkh2016 merged commit f9dc6eb into PaddlePaddle:develop May 11, 2023
lijialin03 pushed a commit to lijialin03/Paddledocs that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants