-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_depthwise_conv2d_transpose #53680
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
|
||
def depthwiseconv2dtranspose_forward_naive(input_, filter_, attrs): | ||
print("depthwise_conv2d_transpose2d_forward_naive") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的print是不是忘删了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确实忘记删了,这块我改一下。
def test_check_grad_no_input(self): | ||
if self.need_check_grad: | ||
self.check_grad_with_place( | ||
self.place, ['Filter'], 'Output', no_grad_set={'Input'} | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
方法是test_check_grad,为什么方法里面有一个变量来控制是否check_grad?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我看有些test脚本里面考虑到了不测试grad情况。(个人觉得可能是因为考虑到了训练版算子和推理版。)因此就也加了变量控制一下,方便后期代码复用。考虑到目前是训练版本,所以那个控制变量设置的为true。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
OPs
Description
add op and op_test