Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_depthwise_conv2d_transpose #53680

Merged
merged 3 commits into from
May 11, 2023
Merged

add_depthwise_conv2d_transpose #53680

merged 3 commits into from
May 11, 2023

Conversation

SaltFish11
Copy link
Contributor

PR types

New features

PR changes

OPs

Description

add op and op_test

@paddle-bot
Copy link

paddle-bot bot commented May 10, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 10, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 10, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

YuanRisheng
YuanRisheng previously approved these changes May 10, 2023
ykkk2333
ykkk2333 previously approved these changes May 11, 2023
Copy link
Contributor

@ykkk2333 ykkk2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM



def depthwiseconv2dtranspose_forward_naive(input_, filter_, attrs):
print("depthwise_conv2d_transpose2d_forward_naive")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的print是不是忘删了?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实忘记删了,这块我改一下。

Comment on lines +190 to +194
def test_check_grad_no_input(self):
if self.need_check_grad:
self.check_grad_with_place(
self.place, ['Filter'], 'Output', no_grad_set={'Input'}
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

方法是test_check_grad,为什么方法里面有一个变量来控制是否check_grad?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看有些test脚本里面考虑到了不测试grad情况。(个人觉得可能是因为考虑到了训练版算子和推理版。)因此就也加了变量控制一下,方便后期代码复用。考虑到目前是训练版本,所以那个控制变量设置的为true。

@SaltFish11 SaltFish11 dismissed stale reviews from ykkk2333 and YuanRisheng via 92c48b6 May 11, 2023 03:11
Copy link
Contributor

@RuohengMa RuohengMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit 08b6f5d into PaddlePaddle:develop May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants