Cinn schedule error #54983

ZzSean · 2023-06-29T04:46:16Z

PR types

Others

PR changes

Others

Description

新增Schedule报错处理机制

card-72613

内容：

新增异常处理数据结构。不同schedule primitive通过继承基类IRScheduleErrorHandler，完成不同的报错信息打印
分层级打印报错信息。通过向ScheduleImpl中新增ScheduleErrorMessageLevel，决定后续出现错误时的报错打印层级，可通过运行时的FLAGS控制
使用宏简化代码
该PR以Split为例，展示如何在代码中使用新的报错处理机制
添加异常单测
自定义CINN_THROW，与主框架的PADDLE_THROW报错信息内容保持一致

效果：

之前schedule出错会直接core dumped，可运行schedule单测复现
添加新的异常处理机制后，会抛出异常但不会core dumped，且可以控制报错信息打印层级和报错信息
报错信息如下：

--------------------------------------
C++ Traceback (most recent call last):
--------------------------------------
0 cinn::ir::IRSchedule::Split(cinn::ir::Expr const&, std::vector<int, std::allocator<int> > const&)
1 cinn::ir::IRSchedule::Split(cinn::ir::Expr const&, std::vector<cinn::ir::Expr, std::allocator<cinn::ir::Expr> > const&)
2 cinn::ir::enforce::EnforceNotMet::EnforceNotMet(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, char const*, int)

----------------------
Error Message Summary:
----------------------
[IRScheduleError] An error occurred in the scheduel primitive <split>. 
[Error info] The params in factors of Split should not be less than -1 or have more than one -1!
(at /root/paddlejob/workspace/work/zhangzheng/Paddle/paddle/cinn/ir/ir_schedule.cc : 179)

paddle-bot · 2023-06-29T04:46:20Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhangbo9674

LGTM for std::cout

paddle/cinn/ir/ir_schedule_error.h

zhhsplendid · 2023-07-07T09:18:33Z

paddle/cinn/ir/ir_schedule_error.h

+#define CINN_THROW(...)                                              \
+  do {                                                               \
+    try {                                                            \
+      throw enforce::EnforceNotMet(__VA_ARGS__, __FILE__, __LINE__); \


Is this same as Paddle enforce? As I remember, we discussed offline that we use PADDLE_THROW when we found the definition, otherwise we define by ourself, then we can handle it with both CINN-only and Paddle-CINN.

Does this implementation also handle both CINN-only and Paddle-CINN? Do we reuse Paddle code?

PADDLE_THROW is more complicated and has many redundant functions. If we want to reuse Paddle code we have to include more Paddle header files, thus we cannot build CINN-ONLY.
Using CINN_THROW defined by ourselves maybe a good solution for now, 'cause there is IR_THROW in PADDLE_IR to deal with the similar problem.

OK, not best but fine to me now.

zhhsplendid · 2023-07-07T09:20:37Z

paddle/cinn/ir/ir_schedule_error.h

+/**
+ *  \brief Indicates the level of printing error message in the current Schedule
+ */
+enum class ScheduleErrorMessageLevel : int32_t {


Can the ErrorMessage use at other places? If so, should we remove Schedule in naming? Then we can use the code you implemented all over the CINN!

Technically no problem. But its namespace is cinn::ir now, i don't know if it is convenient/necessary to use this in the same level of ir, like hlir, optim, etc.

What about changing the name and the location of this file when we have the need later?

If so, can we change the namespace, location of file in this PR? We would like to reuse for other places.

paddle/cinn/ir/ir_schedule_error.h

zhhsplendid · 2023-07-07T09:26:32Z

paddle/cinn/runtime/flags.cc

@@ -160,6 +160,11 @@ DEFINE_int32(cinn_profiler_state,
             "Specify the ProfilerState by Int in CINN, 0 for kDisabled, 1 for "
             "kCPU, 2 for kCUDA, 3 for kAll, default 0.");

+DEFINE_int32(cinn_schedule_error_message_level,


Same as my other comment, can the ErrorMessage be use at other places? If so, should we remove "schedule" text in the flag? Then we can use the code you implemented all over the CINN!

zhhsplendid · 2023-07-07T09:32:26Z

paddle/cinn/ir/ir_schedule_util.cc

+
+  class InferFactorErrorHandler : public IRScheduleErrorHandler {
+   public:
+    explicit InferFactorErrorHandler(const ModuleExpr& module_expr)


Will it be complex if we have to implement sub-classes of IRScheduleErrorHandler at where we want to report error?

I thought we have a ErrorHandler class which can set general error message and detailed message, then we just input strings at where we want to report error.

Two reasons:

Different kinds of schedule primitive require different error messages, so using abstract class and sub-classes is to deal with their own special need for this.

Implementation of error message inside each subclass is easier to use the macro to simplify the code.

zhangbo9674

LGTM for cout

zhhsplendid · 2023-07-13T05:53:19Z

Discussed offline, we approve this PR now, but above unresolved comments will be changed in the future PRs.

zhhsplendid

LGTM

* [CINN] Schedule error message optimization * format code style * add test * fix format * using CINN_THROW and using flags * optimize error msg * do not use abtract class of error hanlder * fix header

ZzSean added 2 commits June 28, 2023 08:22

[CINN] Schedule error message optimization

35c1bb8

format code style

3194cb4

Merge branch 'develop' into cinn_schedule_error

9394b6b

ZzSean force-pushed the cinn_schedule_error branch from 25b4706 to 2d2ce5f Compare July 3, 2023 03:22

fix

ba6204e

ZzSean force-pushed the cinn_schedule_error branch from 2d2ce5f to ba6204e Compare July 3, 2023 06:22

ZzSean added 2 commits July 3, 2023 14:27

Merge branch 'develop' into cinn_schedule_error

b665e6a

add test

272c385

ZzSean force-pushed the cinn_schedule_error branch from 46c8e53 to 272c385 Compare July 3, 2023 08:23

ZzSean added 7 commits July 4, 2023 10:30

Merge branch 'develop' into cinn_schedule_error

1cf6bf1

fix format

501f345

using CINN_THROW and using flags

d90753b

optimize error msg

8b769c6

fix

28de4a0

fix

15a467b

fix annotate

b4d5945

zhangbo9674 previously approved these changes Jul 7, 2023

View reviewed changes

zhhsplendid reviewed Jul 7, 2023

View reviewed changes

ZzSean added 2 commits July 10, 2023 14:44

Merge branch 'develop' into cinn_schedule_error

7838c2e

fix comments

c4ae9fd

ZzSean dismissed zhangbo9674’s stale review via c4ae9fd July 10, 2023 06:47

ZzSean added 3 commits July 12, 2023 13:05

do not use abtract class of error hanlder

bd9c76b

fix

ba22886

fix header

f159e42

zhangbo9674 approved these changes Jul 13, 2023

View reviewed changes

zhhsplendid approved these changes Jul 13, 2023

View reviewed changes

ZzSean merged commit 5f05b22 into PaddlePaddle:develop Jul 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cinn schedule error #54983

Cinn schedule error #54983

ZzSean commented Jun 29, 2023 •

edited

Loading

paddle-bot bot commented Jun 29, 2023

zhangbo9674 left a comment

zhhsplendid Jul 7, 2023

ZzSean Jul 10, 2023 •

edited

Loading

zhhsplendid Jul 11, 2023

zhhsplendid Jul 7, 2023

ZzSean Jul 10, 2023

ZzSean Jul 10, 2023

zhhsplendid Jul 11, 2023

zhhsplendid Jul 7, 2023

zhhsplendid Jul 7, 2023

ZzSean Jul 10, 2023 •

edited

Loading

zhangbo9674 left a comment

zhhsplendid commented Jul 13, 2023

zhhsplendid left a comment

Cinn schedule error #54983

Cinn schedule error #54983

Conversation

ZzSean commented Jun 29, 2023 • edited Loading

PR types

PR changes

Description

paddle-bot bot commented Jun 29, 2023

zhangbo9674 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZzSean Jul 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZzSean Jul 10, 2023 • edited Loading

Choose a reason for hiding this comment

zhangbo9674 left a comment

Choose a reason for hiding this comment

zhhsplendid commented Jul 13, 2023

zhhsplendid left a comment

Choose a reason for hiding this comment

ZzSean commented Jun 29, 2023 •

edited

Loading

ZzSean Jul 10, 2023 •

edited

Loading

ZzSean Jul 10, 2023 •

edited

Loading