Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cinn schedule error #54983
Cinn schedule error #54983
Changes from 13 commits
35c1bb8
3194cb4
9394b6b
ba6204e
b665e6a
272c385
1cf6bf1
501f345
d90753b
8b769c6
28de4a0
15a467b
b4d5945
7838c2e
c4ae9fd
bd9c76b
ba22886
f159e42
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this same as
Paddle
enforce? As I remember, we discussed offline that we usePADDLE_THROW
when we found the definition, otherwise we define by ourself, then we can handle it with both CINN-only and Paddle-CINN.Does this implementation also handle both CINN-only and Paddle-CINN? Do we reuse Paddle code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PADDLE_THROW
is more complicated and has many redundant functions. If we want to reuse Paddle code we have to include more Paddle header files, thus we cannot build CINN-ONLY.Using
CINN_THROW
defined by ourselves maybe a good solution for now, 'cause there isIR_THROW
inPADDLE_IR
to deal with the similar problem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, not best but fine to me now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the ErrorMessage use at other places? If so, should we remove
Schedule
in naming? Then we can use the code you implemented all over the CINN!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically no problem. But its namespace is
cinn::ir
now, i don't know if it is convenient/necessary to use this in the same level ofir
, likehlir
,optim
, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing the name and the location of this file when we have the need later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, can we change the namespace, location of file in this PR? We would like to reuse for other places.