Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xdoctest] reformat example code with google style in No.48&49 #55868

Merged
merged 3 commits into from
Aug 2, 2023
Merged

[xdoctest] reformat example code with google style in No.48&49 #55868

merged 3 commits into from
Aug 2, 2023

Conversation

sunzhongkai588
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 commented Aug 1, 2023 •
edited
Loading

@paddle-bot
Copy link

paddle-bot bot commented Aug 1, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@sunzhongkai588 sunzhongkai588 mentioned this pull request Aug 1, 2023
Closed
@sunzhongkai588 sunzhongkai588 changed the title [Doctest]fix No.48&49, test=docs_preview [Fix]XDoctest No.48&49, test=docs_preview Aug 1, 2023
@sunzhongkai588 sunzhongkai588 changed the title [Fix]XDoctest No.48&49, test=docs_preview [Fix]XDoctest No.48&49 Aug 1, 2023
SigureMo
SigureMo previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow~~~~~~

@megemini
Copy link
Contributor

megemini commented Aug 1, 2023

LGTM ：）

@SigureMo
Copy link
Member

SigureMo commented Aug 1, 2023

@megemini LGTM 用 review 会更合适一些～可以 LGTM + approve

image

megemini
megemini approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ：）

SigureMo
SigureMo approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow~

@SigureMo SigureMo changed the title [Fix]XDoctest No.48&49 [xdoctest] reformat example code with google style in No.48&49 Aug 1, 2023
@luotao1 luotao1 merged commit 5e96126 into PaddlePaddle:develop Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

@megemini megemini megemini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunzhongkai588 @megemini @SigureMo @luotao1