Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xdoctest][task 355] reformat example code with google style in pir.cc #58177

Merged
merged 4 commits into from
Nov 2, 2023
Merged

[xdoctest][task 355] reformat example code with google style in pir.cc #58177

merged 4 commits into from
Nov 2, 2023

Conversation

DrRyanHuang
Copy link
Member

@DrRyanHuang DrRyanHuang commented Oct 18, 2023

PR types

Others

PR changes

Others

Description

修改如下文件的示例代码,使其通过 xdoctest 检查:

paddle/fluid/pybind/pir.cc

Related links

由于目前需要等待 #56550 合入(我这俩天尽快搞定😭)(已合入)
后 2/3 的doc才可以修改,先把pr放上来

目前发现依旧存在该问题

Input [x] of op [elementwise_add] not found in param map
可能是 op_translator.cc 映射的问题,待排查

@paddle-bot
Copy link

paddle-bot bot commented Oct 18, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 18, 2023
@paddle-bot
Copy link

paddle-bot bot commented Oct 18, 2023

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 18, 2023
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 26, 2023

Sorry to inform you that 4367bf0's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@DrRyanHuang
Copy link
Member Author

第 3 批最后一个任务? 🤣🤣🤣

2023-10-31 07:13:38 **************************************************************
2023-10-31 07:13:38 Please find RD for approval first, and then find TPM for approval.
2023-10-31 07:13:38 0. print or std::cout is not recommended for direct use, please use logging or VLOG. If it is necessary to use, please contact tianshuo78520a (Recommend) or zhangbo9674 review and approve.
2023-10-31 07:13:38 
2023-10-31 07:13:38 There are 1 approved errors.
2023-10-31 07:13:38 **************************************************************

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

变量名里的 new_ir 改成 pir 吧,有些不能改的地方不用改

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@luotao1 luotao1 merged commit 53e5a2d into PaddlePaddle:develop Nov 2, 2023
28 checks passed
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants