-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR API adaptor No.45-47】Migrate some ops into pir #58682
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
PR-CI-Py3 挂掉的地方在:
|
crop的问题是由于这里适配的单测是废弃算子的单测,这里由于算子的历史原因名字有误导性,真正需要适配的单测是test_crop_tensor_op.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_softmax_with_cross_entropy_op单测中的check_grad会在windows上失败。这里的check_grad先设置成check_pir=False,我们内部看下反向的问题
麻烦 pre-commit 一下 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
请在 pr 描述里记录目前跳过 test_softmax_with_cross_entropy_op 的 check_grad 的相关单测,并更新单测覆盖率
PR types
Others
PR changes
APIs
Description
PIR API 推全升级
将如下算子迁移升级至 pir,并更新单测
crop(7/10):总计 10 个单测,打开7个单测,3个单测用来测试边界和error的
cross(5/5)
softmax_with_cross_entropy(43/44):总计 44 个单测,打开43个单测,1个单测用来测试error的,暂时关闭test_softmax_with_cross_entropy_op 的 check_grad 的相关单测因为windows ci会报错
新IR Python API适配升级 #58067