[PIR]Fix cross_entropy_with_softmax vjp bug && check_grad passed #59451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
approved these changes
Nov 29, 2023
| @@ -149,7 +149,7 @@ def gen_op_vjp_str( | |||
| index_0 = fwd_outputs_list.index(bw_input_name) | |||
| else: | |||
| vjp_param_name = 'out_grads' | |||
| grad_idx += 1 | |||
| grad_idx = fwd_outputs_list.index(bw_input_name[:-5]) | |||
There was a problem hiding this comment.
Suggested change
| grad_idx = fwd_outputs_list.index(bw_input_name[:-5]) | |
| offset = len("_grad") | |
| grad_idx = fwd_outputs_list.index(bw_input_name[:-offset]) |
这里建议不要直接写 -5，不熟悉背景的其他开发者会比较奇怪这个magic_number 是怎么来的。之前我升级gen.py时遇到过影响其他magic_number导致CI失败问题，排查起来不是很友好。
0x45f
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
pcard-67164
Fix cross_entropy_with_softmax vjp bug && check_grad passed