Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Important] DO NOT Support Py3.7 Since Paddle Version 2.6.0 and Forbid in CMake #59680

Merged
merged 4 commits into from
Dec 12, 2023
Merged

[Important] DO NOT Support Py3.7 Since Paddle Version 2.6.0 and Forbid in CMake #59680

merged 4 commits into from
Dec 12, 2023

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Dec 5, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

Forbid py37
Pcard-67164

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 5, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

risemeup1
risemeup1 reviewed Dec 5, 2023
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
python/setup.py.in Show resolved Hide resolved
SigureMo
SigureMo reviewed Dec 5, 2023
View reviewed changes
python/setup.py.in Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
SigureMo
SigureMo previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

Aurelius84
Aurelius84 previously approved these changes Dec 5, 2023
View reviewed changes
risemeup1
risemeup1 previously approved these changes Dec 5, 2023
View reviewed changes
@Aurelius84 Aurelius84 changed the title Forbid py37 DO NOT Support Py37 Since Paddle Version 2.6.0 Dec 5, 2023
@Aurelius84 Aurelius84 changed the title DO NOT Support Py37 Since Paddle Version 2.6.0 DO NOT Support Py3.7 Since Paddle Version 2.6.0 Dec 5, 2023
@Aurelius84 Aurelius84 changed the title DO NOT Support Py3.7 Since Paddle Version 2.6.0 [Important] DO NOT Support Py3.7 Since Paddle Version 2.6.0 Dec 5, 2023
@Aurelius84 Aurelius84 changed the title [Important] DO NOT Support Py3.7 Since Paddle Version 2.6.0 [Important] DO NOT Support Py3.7 Since Paddle Version 2.6.0 and Forbind in CMake Dec 5, 2023
@Aurelius84 Aurelius84 changed the title [Important] DO NOT Support Py3.7 Since Paddle Version 2.6.0 and Forbind in CMake [Important] DO NOT Support Py3.7 Since Paddle Version 2.6.0 and Forbid in CMake Dec 5, 2023
zrr1999
zrr1999 previously approved these changes Dec 5, 2023
View reviewed changes
gouzil
gouzil previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@gouzil gouzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

干得漂亮，终于退场了，LGTM

@Aurelius84
Copy link
Contributor

@0x45f 此PR 待2.6分支拉出后，再合入。即2.6分支不在Cmake层禁止

@0x45f
Copy link
Contributor Author

0x45f commented Dec 6, 2023

@0x45f 此PR 待2.6分支拉出后，再合入。即2.6分支不在Cmake层禁止

好的~

@SigureMo SigureMo mentioned this pull request Dec 6, 2023
Merged
@SigureMo SigureMo dismissed stale reviews from gouzil, zrr1999, risemeup1, Aurelius84, and themself via 03fc2b4 December 9, 2023 06:38
@SigureMo SigureMo mentioned this pull request Dec 9, 2023
Merged
This was referenced Dec 10, 2023
Merged
Merged
Merged
@gouzil gouzil mentioned this pull request Dec 10, 2023
Closed
8 tasks
SigureMo
SigureMo approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@luotao1 luotao1 merged commit efad2b1 into PaddlePaddle:develop Dec 12, 2023
29 checks passed
@0x45f 0x45f deleted the forbid-py37 branch September 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risemeup1 risemeup1 risemeup1 approved these changes

@SigureMo SigureMo SigureMo approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@gouzil gouzil gouzil left review comments

@zrr1999 zrr1999 zrr1999 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@0x45f @Aurelius84 @SigureMo @zrr1999 @risemeup1 @gouzil @luotao1