[build][ipu] cleanup 3.7 for build shell - Part2 #59876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
可以看下CI流水线会不会有问题 |
gouzil
commented
Dec 12, 2023
| @@ -920,7 +920,7 @@ function checkMacPip(){ | |||
| if [[ "$version_list" != "" ]];then | |||
| return 0 | |||
| else | |||
| red "未找到可用的pip或pip3。PaddlePaddle目前支持：Python >= 3.7及其对应的pip, 请重新输入，或使用ctrl + c退出" | |||
There was a problem hiding this comment.
这个脚本都太久没人维护了，看看是不是可以删了，或者在下个pr维护一下
paddle/scripts/paddle_build.sh
Outdated
| @@ -4256,12 +4277,12 @@ function main() { | |||
| cmake_gen ${PYTHON_ABI:-""} | |||
| build_mac | |||
| ;; | |||
| cicheck_py37) | |||
There was a problem hiding this comment.
@risemeup1 帮忙看一下PR-CI-Py3
There was a problem hiding this comment.
这个应该是写死在流水线配置里的，这个 PR 不要改吧？否则需要和配置一起改。而且现在 PR-CI-Py3 应该是 3.10
paddle/scripts/paddle_build.sh
Outdated
| export WITH_SHARED_PHI=ON | ||
| run_setup ${PYTHON_ABI:-""} bdist_wheel ${parallel_number} | ||
| run_linux_cpu_test ${PYTHON_ABI:-""} ${PROC_RUN:-1} | ||
| ;; | ||
| test_cicheck_py37) |
Done |
luotao1
approved these changes
Dec 14, 2023
risemeup1
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
本pr主要清理编译的 shell
相关链接:
(请先合入 #59680 和 #59871)