Sequence Parallel Support Overlap #62284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
FeixLiu
reviewed
Mar 14, 2024
| ctx.model_parallel_group = model_parallel_group | ||
|
|
||
| world_size = model_parallel_group.nranks | ||
| is_mp = world_size > 1 |
FeixLiu
approved these changes
Mar 18, 2024
Xreki
reviewed
Mar 18, 2024
| input_parallel = x | ||
| output = self.linear( | ||
| input_parallel, self.weight, self.bias, name=self._name | ||
| # sequence parallelism is same as model parallelis, if sequence parallel is true, input shape is [s, b, h],else input shape is [b, s, h] |
There was a problem hiding this comment.
mp_async_allreduce也会有单独开启的情况，即mp_async_allreduce=True、mp_fused_linear_param_grad_add=False？可以在下个PR支持下。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Description
1、本PR主要支持SP支持计算通信重叠功能
2、逐位对齐实验结果，在llama2 13B上开main_grad逐位对齐结果如下，bf16 main_grad, fp16 main_grad，bf16 no main_grad, fp16 no main_grad均能逐位对齐
3、更新前后的timeline结果对比
Pcard-73145