Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] fix distdataloader #8420

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

  1. Fix distdataloder when using tp;
  2. Fix eval under data parallel group.

Copy link

paddle-bot bot commented May 11, 2024

Thanks for your contribution!

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.43%. Comparing base (9146c1e) to head (e55fae8).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8420      +/-   ##
===========================================
- Coverage    55.43%   55.43%   -0.01%     
===========================================
  Files          616      616              
  Lines        96229    96241      +12     
===========================================
+ Hits         53346    53348       +2     
- Misses       42883    42893      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DesmonDay DesmonDay changed the title [Trainer] fix distdataloader, fix eval with dp group [Trainer] fix distdataloader May 11, 2024
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 6bd2b0d into PaddlePaddle:develop May 13, 2024
9 of 11 checks passed
DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request May 13, 2024
DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request May 13, 2024
DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request May 13, 2024
DesmonDay added a commit that referenced this pull request May 13, 2024
* [DistDataloader] Update implementation, add nested.py (#8380)
* fix distdataloader, fix eval with dp group (#8420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants