Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trainer] update distributed dataloader #8426

Merged
merged 2 commits into from
May 13, 2024
Merged

[Trainer] update distributed dataloader #8426

merged 2 commits into from
May 13, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Cherry-pick #8380
Cherry-pick #8420

DesmonDay and others added 2 commits May 13, 2024 11:12
@DesmonDay @lugimzzz
[DistDataloader] Update implementation, add nested.py (PaddlePaddle#8380
c8dde78 
)

* Fix sharding overlap bug

* [DistDataloader] Update implementation, add nested.py

* Fix pipeline

* add first try

* update dataloader

---------

Co-authored-by: lugimzzz <zhenglujing@baidu.com>
@DesmonDay
fix distdataloader, fix eval with dp group (PaddlePaddle#8420)
a21417e
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented May 13, 2024

Thanks for your contribution!

ZHUI
ZHUI approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DesmonDay DesmonDay merged commit debb2ad into PaddlePaddle:release/2.8 May 13, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZHUI ZHUI ZHUI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DesmonDay @ZHUI