-
-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test(organization_search_list): Improved Code Coverage #2645
Test(organization_search_list): Improved Code Coverage #2645
Conversation
This reverts commit 9a7ddb6.
MVVM statemanagement on events.dart and add_event_page.dart
… into update-profile-page-MVVM
- Widgets common between add_event_dialog.dart and edit_event_dialog.dart have been separated into file event_widgets.dart - Data is passed as parameter - Register form also reformatted
Fix: #654 Sort the Organization Names in Join_Organization Page
- Reformatted with flutter format - URL Page Animation extracted and moved to other file
[Refactoring] Dart file size reduction
* lang addition * lng-add * static string removal * language changes * chgs in main * test update
* ui added * adding lng widget * bug fix * test upd
* chore: fixes linting issue * ptch: replaces event list with displayed events list
* Replacing extra widgets for toasts with Custom Toast and making it uniform * removed snackbar.dart due to no implementation * flutter format * merge conflict resolved
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
* Add files via upload * Update pull-request.yml
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main --------- Co-authored-by: Peter Harrison <peter@colovore.com>
* 20240727112557 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20240727112838 Merge develop into main
* 20240929111306 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20240929111329 Merge develop into main --------- Co-authored-by: Peter Harrison <peter@colovore.com>
* 20241114060032 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20241114060107 Merge develop into main
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 98 files out of 180 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
What kind of change does this PR introduce?
This PR improves the code coverage of the
organization_search_list.dart
file from 79% to 94.59%, a significant improvement. These changes provide a solid foundation to further enhance coverage to 100% with the addition of a few more tests. The core functionalities of the file remain unchanged.Issue Number
Fixes #1293
Furthered referenced in #1125
Did you add tests for your changes?
Yes
Snapshots/Videos
If relevant, did you update the documentation?
Not Needed
Summary
This PR introduces new tests for
lib/widgets/organization_search_list.dart
, located in the test file:test/widget_tests/widgets/organization_search_list_test.dart
.Additionally, minor updates were made to
lib/widgets/organization_search_list.dart
to improve test compatibility while ensuring the core functionality remains intact.Does this PR introduce a breaking change?
No
Other Information
Does not change core functions and provides a baseline for further improvements
Have you read the Contributing Guide?
Yes