-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sounds for welcoming the crew to the station #26666
Conversation
Not too sure how i feel about the cerebron one tbh, its pronouncing it like "cerebern" when it should be "cere-bron" |
Also the Kerberos one is speaking too fast, i'd see how it sounds with "welcome to the Kerberos, crew" rather than "Kerberos crew" |
It might be better as "Welcome to the NSS x" as opposed to tacking a crew on the end, sounds a bit funky personally. Like the idea though! I think you can modify pronunciation using phonemes in Amazon Polly so you could have it properly pronounce Cerebron https://aws.amazon.com/blogs/machine-learning/customize-pronunciations-using-amazon-polly/ |
@S34NW updated the sounds with your idea, I do think it sounds a ton better. Videos updated with the new sounds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like its missing "crew" before the 'enjoy your stay'. but other than that, it sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually, since #26438 was merged, this needs a new soundclip for the NSS Diagoras
Added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhh yeah I'm thinking
SEND IT
(still requires AA review)
What Does This PR Do
Adds a sound for each station on the roundstart welcome message.
Thanks go to @Contrabang for helping me with the code side of things!
Why It's Good For The Game
More variety with sounds is good!
Images of changes
NSS Cerebron:
cerebron.mp4
NSS Cyberiad:
cyberiad.mp4
NSS Farragus:
farragus.mp4
NSS Kerberos:
kerberos.mp4
NSS Diagoras:
diagoras.mp4
Fallback for when there is no sound for the map:
nomap.mp4
Testing
Loaded each station and test_tiny to make sure that the sounds play correctly per station.
Declaration
Changelog
🆑
soundadd: added new roundstart welcome messages for each station
/:cl: