Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sounds for welcoming the crew to the station #26666

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

Code-Lyoko0
Copy link
Contributor

@Code-Lyoko0 Code-Lyoko0 commented Sep 2, 2024

What Does This PR Do

Adds a sound for each station on the roundstart welcome message.

Thanks go to @Contrabang for helping me with the code side of things!

Why It's Good For The Game

More variety with sounds is good!

Images of changes

NSS Cerebron:

cerebron.mp4

NSS Cyberiad:

cyberiad.mp4

NSS Farragus:

farragus.mp4

NSS Kerberos:

kerberos.mp4

NSS Diagoras:

diagoras.mp4

Fallback for when there is no sound for the map:

nomap.mp4

Testing

Loaded each station and test_tiny to make sure that the sounds play correctly per station.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
soundadd: added new roundstart welcome messages for each station
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sound This PR modifies the game sound labels Sep 2, 2024
@1080pCat
Copy link
Contributor

1080pCat commented Sep 2, 2024

Not too sure how i feel about the cerebron one tbh, its pronouncing it like "cerebern" when it should be "cere-bron"

@1080pCat
Copy link
Contributor

1080pCat commented Sep 2, 2024

Also the Kerberos one is speaking too fast, i'd see how it sounds with "welcome to the Kerberos, crew" rather than "Kerberos crew"

@S34NW
Copy link
Member

S34NW commented Sep 2, 2024

It might be better as "Welcome to the NSS x" as opposed to tacking a crew on the end, sounds a bit funky personally. Like the idea though! I think you can modify pronunciation using phonemes in Amazon Polly so you could have it properly pronounce Cerebron

https://aws.amazon.com/blogs/machine-learning/customize-pronunciations-using-amazon-polly/

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 2, 2024
@BiancaWilkson BiancaWilkson added the Feature This PR is a new addition to the game label Sep 3, 2024
@Code-Lyoko0
Copy link
Contributor Author

@S34NW updated the sounds with your idea, I do think it sounds a ton better. Videos updated with the new sounds

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting approval This PR is waiting for approval internally labels Sep 4, 2024
Copy link
Contributor

@1080pCat 1080pCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like its missing "crew" before the 'enjoy your stay'. but other than that, it sounds good

Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Code is Great

image

Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually, since #26438 was merged, this needs a new soundclip for the NSS Diagoras

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Sep 20, 2024
@Code-Lyoko0
Copy link
Contributor Author

Oh actually, since #26438 was merged, this needs a new soundclip for the NSS Diagoras

Added!

Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh yeah I'm thinking

SEND IT

(still requires AA review)

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 21, 2024
@Burzah Burzah added this pull request to the merge queue Sep 30, 2024
Merged via the queue into ParadiseSS13:master with commit 0d79dc6 Sep 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game Sound This PR modifies the game sound
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants