Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum node and npm versions #2475

Merged
merged 1 commit into from
May 13, 2024

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented May 13, 2024

Description

With this PR we're updating the minimum required node version to 18, and npm version to 8.3. The npm update is required to support package.json overrides that we've introduced in #2473.

Motivation and context

Keep our tooling updated.

How has this been tested?

Automated tests pass.

Summary by CodeRabbit

  • Chores
    • Updated the minimum required Node.js version to 18 and npm to version 8.3.

@acicovic acicovic added this to the 3.15.0 milestone May 13, 2024
@acicovic acicovic self-assigned this May 13, 2024
Copy link
Contributor

coderabbitai bot commented May 13, 2024

Walkthrough

Walkthrough

The updates involve increasing the minimum required versions of Node.js and npm in the project configuration files. Specifically, the Node.js version is raised from 16 to 18, and the npm version is updated from 7 to at least 8.3. These changes ensure compatibility with newer technologies and potentially enhance security and performance.

Changes

File Change Summary
.nvmrc Node.js version updated from 16 to 18
package.json Node.js version requirement updated from >=16 to >=18; npm version requirement updated from >=7 to >=8.3

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@acicovic acicovic marked this pull request as ready for review May 13, 2024 09:21
@acicovic acicovic requested a review from a team as a code owner May 13, 2024 09:21
@acicovic
Copy link
Collaborator Author

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented May 13, 2024

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between e9d1acf and 455f5ea.
Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing (2)
  • .nvmrc (1 hunks)
  • package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • .nvmrc
Additional comments not posted (1)
package.json (1)

23-24: Updated Node.js and npm version requirements to >=18 and >=8.3 respectively.

This update aligns with the PR's objective to utilize the package.json overrides feature and ensures compatibility with newer features. Ensure that all dependencies and scripts are tested with these new version requirements.

@acicovic acicovic merged commit 8851d1b into develop May 13, 2024
37 checks passed
@acicovic acicovic deleted the update/minimum-node-and-npm-versions branch May 13, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants