Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually update npm dependencies #2473

Merged
merged 6 commits into from
May 13, 2024
Merged

Manually update npm dependencies #2473

merged 6 commits into from
May 13, 2024

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented May 13, 2024

Description

We had a dozen of dependabot PRs that were updating Gutenberg components failing tests/builds. This PR updates the dependencies manually to fix the issue.

Steps taken:

  • Run npm update (fixed failing tests).
  • Add override in package.json and run npm i (fixed failing builds).

Big thanks to @sirreal for looking into this and providing these steps that solved the issue! 🙂

Motivation and context

Be able to update our dependencies, unblocking our workflow and getting rid of PRs we cannot merge.

How has this been tested?

Automated testing now passes.

Summary by CodeRabbit

  • New Features

    • Updated the related posts panel to now display posts from the last 30 days, enhancing user insights into recent trends.
  • Bug Fixes

    • Improved the selector accuracy for period settings in the related posts feature, ensuring more reliable functionality. Added a brief delay after setting adjustments to enhance stability.

@acicovic acicovic added Type: Maintenance Component: Dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 13, 2024
@acicovic acicovic added this to the 3.15.0 milestone May 13, 2024
@acicovic acicovic self-assigned this May 13, 2024
Copy link
Contributor

coderabbitai bot commented May 13, 2024

Walkthrough

Walkthrough

The recent updates involve adjustments in managing types and settings for a web application. Notably, the package.json file now includes a new version override for React types. Changes in tests/e2e/... refine how date filters in a related posts panel function and update a selector for period settings, enhancing the test's interaction with UI components.

Changes

File Summary
package.json Added an override for @types/react to version 18.2.65.
tests/e2e/specs/.../related-posts-panel-filters.spec.ts
tests/e2e/utils.ts
Updated to reflect changes in the period from the last 7 days to the last 30 days for top related posts. Selector for period setting updated and a timeout delay of 1000ms added after selection.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@acicovic
Copy link
Collaborator Author

Looking into the failing E2E test issue, which only fails on GitHub.

@acicovic acicovic marked this pull request as ready for review May 13, 2024 08:22
@acicovic acicovic requested a review from a team as a code owner May 13, 2024 08:22
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between df82271 and e59aac7.
Files ignored due to path filters (16)
  • build/blocks/recommendations/edit.asset.php is excluded by !build/**
  • build/blocks/recommendations/edit.js is excluded by !build/**
  • build/blocks/recommendations/view.asset.php is excluded by !build/**
  • build/blocks/recommendations/view.js is excluded by !build/**
  • build/content-helper/dashboard-widget.asset.php is excluded by !build/**
  • build/content-helper/dashboard-widget.js is excluded by !build/**
  • build/content-helper/editor-sidebar.asset.php is excluded by !build/**
  • build/content-helper/editor-sidebar.css is excluded by !build/**
  • build/content-helper/editor-sidebar.js is excluded by !build/**
  • build/content-helper/excerpt-generator.asset.php is excluded by !build/**
  • build/content-helper/excerpt-generator.js is excluded by !build/**
  • build/recommended-widget.asset.php is excluded by !build/**
  • build/recommended-widget.css is excluded by !build/**
  • build/telemetry.asset.php is excluded by !build/**
  • build/telemetry.js is excluded by !build/**
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing (3)
  • package.json (1 hunks)
  • tests/e2e/specs/content-helper/related-posts-panel-filters.spec.ts (1 hunks)
  • tests/e2e/utils.ts (2 hunks)
Files not reviewed due to errors (1)
  • tests/e2e/utils.ts (no review received)
Files skipped from review due to trivial changes (1)
  • package.json
Additional Context Used
Path-based Instructions (2)
tests/e2e/specs/content-helper/related-posts-panel-filters.spec.ts (1)

Pattern **/*.{js,ts,tsx,jsx}: "Perform a detailed review of the provided code with following key aspects in mind:

  • Review the code to ensure it is well-structured and adheres to best practices.
  • Verify compliance with WordPress coding standards.
  • Ensure the code is well-documented.
  • Check for security vulnerabilities and confirm the code is secure.
  • Optimize the code for performance, removing any unnecessary elements.
  • Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
  • Ensure each line comment concludes with a period.
  • Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
  • Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."
tests/e2e/utils.ts (1)

Pattern **/*.{js,ts,tsx,jsx}: "Perform a detailed review of the provided code with following key aspects in mind:

  • Review the code to ensure it is well-structured and adheres to best practices.
  • Verify compliance with WordPress coding standards.
  • Ensure the code is well-documented.
  • Check for security vulnerabilities and confirm the code is secure.
  • Optimize the code for performance, removing any unnecessary elements.
  • Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
  • Ensure each line comment concludes with a period.
  • Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
  • Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."
Additional comments not posted (1)
tests/e2e/specs/content-helper/related-posts-panel-filters.spec.ts (1)

56-56: The update in the test expectation to reflect data from the last 30 days is correctly implemented.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between e59aac7 and 22e8f4f.
Files selected for processing (1)
  • tests/e2e/utils.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • tests/e2e/utils.ts

@acicovic acicovic merged commit e9d1acf into develop May 13, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code Type: Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant