Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge trunk into develop after the wp-parsely 3.16.3 release #2689

Closed
wants to merge 7 commits into from

Conversation

vaurdan
Copy link
Contributor

@vaurdan vaurdan commented Aug 8, 2024

This PR merges the trunk branch into the develop branch after the release of wp-parsely 3.16.3

Summary by CodeRabbit

  • New Features
    • Introduced version 3.16.3 of the Parse.ly plugin with minor improvements and bug fixes.
  • Bug Fixes
    • Addressed an issue with the PCH Smart Linking feature related to undefined variable handling.
  • Documentation
    • Updated CHANGELOG and README files to reflect the new versioning information.
  • Chores
    • Incremented version numbers across various project files to indicate the latest release.

@vaurdan vaurdan added this to the 3.17.0 milestone Aug 8, 2024
@vaurdan vaurdan requested a review from a team as a code owner August 8, 2024 09:51
Copy link
Contributor

coderabbitai bot commented Aug 8, 2024

Walkthrough

Walkthrough

The changes introduce the release of version 3.16.3 for the Parse.ly WordPress plugin, focusing on bug fixes and minor updates. Key updates include a fix for the PCH Smart Linking feature, adjustments to version numbers in various files, and improvements to ensure stability and clarity in documentation. This release aims to enhance user experience by addressing prior issues and maintaining consistent versioning practices.

Changes

File Change Summary
CHANGELOG.md, README.md, package.json, wp-parsely.php Updated version number from 3.16.2 to 3.16.3, reflecting new release with minor fixes and improvements.
src/Endpoints/class-base-api-proxy.php Removed PHPStan ignore directive from the get_data method, improving static analysis compliance.
src/content-helper/editor-sidebar/smart-linking/smart-linking.tsx Modified ALLOWED_BLOCKS to include a fallback value, enhancing robustness against undefined variables.
tests/e2e/utils.ts Updated PLUGIN_VERSION to 3.16.3, aligning with the new release version.

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (3)
src/content-helper/editor-sidebar/smart-linking/smart-linking.tsx (3)

38-38: Update JSDoc comment for ALLOWED_BLOCKS.

The JSDoc comment should include the @since tag indicating the next version of the plugin that includes this change. Update the version to reflect the change made in this PR.

- * @since 3.16.2
+ * @since 3.16.3

Line range hint 44-87:
Components look well-structured. Ensure documentation is complete.

The withSettingsProvider and SmartLinkingInspectorControlPanel components are well-structured and effectively use WordPress hooks and components. Ensure that all components are fully documented and check for any potential security vulnerabilities.

Consider reviewing the documentation for completeness and adding any missing details.


Line range hint 105-141:
Function initSmartLinking is well-structured. Check for performance optimizations.

The initSmartLinking function is well-structured and uses WordPress hooks appropriately. Ensure that the function is secure and consider checking for any performance optimizations that could be applied.

Consider reviewing the function for potential performance improvements.

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e13c847 and 5c89a4f.

Files ignored due to path filters (3)
  • build/content-helper/editor-sidebar.asset.php is excluded by !build/**
  • build/content-helper/editor-sidebar.js is excluded by !build/**
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing (7)
  • CHANGELOG.md (1 hunks)
  • README.md (1 hunks)
  • package.json (1 hunks)
  • src/Endpoints/class-base-api-proxy.php (1 hunks)
  • src/content-helper/editor-sidebar/smart-linking/smart-linking.tsx (1 hunks)
  • tests/e2e/utils.ts (1 hunks)
  • wp-parsely.php (2 hunks)
Files skipped from review due to trivial changes (6)
  • CHANGELOG.md
  • README.md
  • package.json
  • src/Endpoints/class-base-api-proxy.php
  • tests/e2e/utils.ts
  • wp-parsely.php
Additional context used
Path-based instructions (1)
src/content-helper/editor-sidebar/smart-linking/smart-linking.tsx (1)

Pattern **/*.{js,ts,tsx,jsx}: "Perform a detailed review of the provided code with following key aspects in mind:

  • Review the code to ensure it is well-structured and adheres to best practices.
  • Verify compliance with WordPress coding standards.
  • Ensure the code is well-documented.
  • Check for security vulnerabilities and confirm the code is secure.
  • Optimize the code for performance, removing any unnecessary elements.
  • Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
  • Ensure each line comment concludes with a period.
  • Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
  • Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."
Additional comments not posted (1)
src/content-helper/editor-sidebar/smart-linking/smart-linking.tsx (1)

Line range hint 1-13:
Imports and structure look good. Verify compatibility.

The imports are well-organized and necessary for the functionality. Ensure that all imported functions and components are compatible with the latest version of WordPress.

@acicovic
Copy link
Collaborator

acicovic commented Aug 8, 2024

Closing in favor of #2690, due to the merge conflicts.

@acicovic acicovic closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants