-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge trunk into develop after the wp-parsely 3.16.3 release #2690
Conversation
…16.3 Update version number and changelog for 3.16.3 release
Release wp-parsely 3.16.3
…elop-after-1.16.3
WalkthroughWalkthroughThe recent update to the Parse.ly WordPress plugin version 3.16.3 includes a critical fix for the PCH Smart Linking feature, addressing an issue with an undefined variable. This release also updates version numbers across various files, enhancing clarity and ensuring consistent tracking of functionalities. The changes ensure that the plugin is more robust and reliable while maintaining compatibility with existing systems. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
src/content-helper/editor-sidebar/smart-linking/smart-linking.tsx (1)
Line range hint
11-36
:
Review JSDoc comments for completeness and accuracy.The JSDoc comments are present but should include a
@since
tag for the new version of the plugin. Ensure that all JSDoc comments are complete and accurate./** * Default maximum number of links to show in the smart linking panel. * * @since 3.14.0 */ +// @since 3.16.3 export const DEFAULT_MAX_LINKS = 10; /** * The allowed blocks for Smart Linking. * * @since 3.16.2 */ +// @since 3.16.3 export const ALLOWED_BLOCKS = window.wpParselySmartLinkingAllowedBlocks ?? [ 'core/paragraph' ];
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (3)
build/content-helper/editor-sidebar.asset.php
is excluded by!build/**
build/content-helper/editor-sidebar.js
is excluded by!build/**
package-lock.json
is excluded by!**/package-lock.json
Files selected for processing (6)
- CHANGELOG.md (1 hunks)
- README.md (1 hunks)
- package.json (1 hunks)
- src/content-helper/editor-sidebar/smart-linking/smart-linking.tsx (1 hunks)
- tests/e2e/utils.ts (1 hunks)
- wp-parsely.php (2 hunks)
Files skipped from review due to trivial changes (5)
- CHANGELOG.md
- README.md
- package.json
- tests/e2e/utils.ts
- wp-parsely.php
Additional context used
Path-based instructions (1)
src/content-helper/editor-sidebar/smart-linking/smart-linking.tsx (1)
Pattern
**/*.{js,ts,tsx,jsx}
: "Perform a detailed review of the provided code with following key aspects in mind:
- Review the code to ensure it is well-structured and adheres to best practices.
- Verify compliance with WordPress coding standards.
- Ensure the code is well-documented.
- Check for security vulnerabilities and confirm the code is secure.
- Optimize the code for performance, removing any unnecessary elements.
- Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
- Ensure each line comment concludes with a period.
- Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
- Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."
Additional comments not posted (3)
src/content-helper/editor-sidebar/smart-linking/smart-linking.tsx (3)
38-38
: Robustness improvement with nullish coalescing.The use of the nullish coalescing operator ensures that
ALLOWED_BLOCKS
always has a valid value, preventing potential runtime errors ifwindow.wpParselySmartLinkingAllowedBlocks
isnull
orundefined
. This is a good practice for enhancing code robustness.
Line range hint
1-8
:
Ensure compliance with WordPress coding standards.The import statements and usage of WordPress dependencies appear to follow WordPress coding standards. Ensure that all dependencies are up-to-date and compatible with the latest WordPress version.
38-38
: Security check for usage of global variables.The use of
window.wpParselySmartLinkingAllowedBlocks
should be verified to ensure it doesn't introduce security vulnerabilities. Validate that this global variable is properly sanitized and controlled.
This PR merges the trunk branch into the develop branch after the release of wp-parsely 3.16.3.
Summary by CodeRabbit
New Features
Bug Fixes
wpParselySmartLinkingAllowedBlocks
in the PCH Smart Linking functionality, enhancing overall stability.Documentation
Chores