Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerable dependencies #2786

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Fix vulnerable dependencies #2786

merged 3 commits into from
Sep 17, 2024

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented Sep 17, 2024

Description

This PR updates some vulnerable dependencies to non-vulnerable versions.

Motivation and context

We shouldn't rely on vulnerable dependencies.

How has this been tested?

  • npm audit returns found 0 vulnerabilities.
  • Automated testing passes.

Summary by CodeRabbit

  • Chores
    • Added an "overrides" section in the package configuration to ensure compatibility with the current version of dependencies.
    • Included comments for future reference regarding the removal of the override once the relevant package is upgraded.

@acicovic acicovic added Component: Dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 17, 2024
@acicovic acicovic added this to the 3.17.0 milestone Sep 17, 2024
@acicovic acicovic self-assigned this Sep 17, 2024
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Walkthrough

Walkthrough

The changes introduce an "overrides" section in the package.json file, specifically adding an override for the puppeteer-core package with a version set to ^23.1.0. Additionally, a comment is included under "overridesComments," indicating that this override should be removed once the @wordpress/scripts package is upgraded to version 29 or greater. This adjustment aims to maintain compatibility with the current version of @wordpress/scripts.

Changes

File Change Summary
package.json Added "overrides": { "puppeteer-core": "^23.1.0" } and "overridesComments": { "puppeteer-core": "Remove once we have upgraded @wordpress/scripts to v29 or greater. See https://github.com/WordPress/gutenberg/pull/64597" }

Possibly related PRs

Suggested labels

Type: Maintenance


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8717392 and 70d4b55.

Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing (1)
  • package.json (1 hunks)
Additional comments not posted (2)
package.json (2)

89-91: LGTM!

The addition of the "overrides" section to specify a version constraint for the puppeteer-core package is a good practice to ensure compatibility and stability. The chosen version (^23.1.0) likely addresses any known issues or vulnerabilities.


92-94: Excellent documentation!

The addition of the "overridesComments" section to provide context for the puppeteer-core version override is highly appreciated. It clearly explains the reasoning behind the override and the conditions for its removal. The reference to the related pull request is also helpful for understanding the broader context.

Good job on documenting this temporary configuration!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@acicovic acicovic marked this pull request as ready for review September 17, 2024 11:32
@acicovic acicovic merged commit 85551a4 into develop Sep 17, 2024
37 checks passed
@acicovic acicovic deleted the fix/vulnerable-dependencies branch September 17, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant