Add a step to the node CI test to confirm built scripts are included in the change #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The screenshots indicate that it's trying to protect against two cases, but the error message only points towards one? |
GaryJones
reviewed
Sep 13, 2021
.github/workflows/node.js.yml
Outdated
| echo "$REPOSTATUS"; | ||
| exit 1; | ||
| else | ||
| echo The repo file system is clean.; |
There was a problem hiding this comment.
While true, it isn't indicative of what was actually being checked - that built files are present or not. Right now, those unfamiliar may not be able to join the dots between whether the file system is clean (is that good or bad?) and the real potential problem.
There was a problem hiding this comment.
I've added a clarification message regarding this.
pauarge
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After CI runs
npm run build, flag the branch a failure if any uncommitted changes are detected.Motivation and Context
Currently, there's no enforcement that built JS files are included when the source changes (or if build tooling alters the build). This seeks to provide some protection that build files are kept up to date with those changes.
How Has This Been Tested?
See the commit history & screen shots below.
Screenshots (if appropriate):
Types of changes
Dev Tooling