Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a step to the node CI test to confirm built scripts are included in the change #374

Merged
merged 12 commits into from
Sep 21, 2021
11 changes: 11 additions & 0 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,16 @@ jobs:
- name: Build application
run: npm run build

- name: Confirm the build is up-to-date
run: |
REPOSTATUS=`git status --porcelain 2>/dev/null`;
if [[ -n "$REPOSTATUS" ]]; then
echo "Repo is not clean. Did you forget to commit changes to the /build dir?";
echo "$REPOSTATUS";
exit 1;
else
echo The repo file system is clean.;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While true, it isn't indicative of what was actually being checked - that built files are present or not. Right now, those unfamiliar may not be able to join the dots between whether the file system is clean (is that good or bad?) and the real potential problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a clarification message regarding this.

fi

- name: Run tests
run: npm test