Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't override random.effects = TRUE #2625

Merged
merged 3 commits into from
Jun 4, 2020
Merged

don't override random.effects = TRUE #2625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9521887
don't override random.effects = TRUE
dlebauer Jun 3, 2020
5fe037d
Update CHANGELOG.md
dlebauer Jun 3, 2020
6562b58
Update modules/meta.analysis/R/meta.analysis.R
dlebauer Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ For more information about this file see also [Keep a Changelog](http://keepacha
- When building sipnet model would not set correct model version
- Update pecan/depends docker image to have latest Roxygen and devtools.
- Update ED docker build, will now build version 2.2.0 and git
- Do not override meta-analysis settings random-effects = FALSE https://github.com/PecanProject/pecan/pull/2625

### Changed

Expand Down
9 changes: 4 additions & 5 deletions modules/meta.analysis/R/meta.analysis.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,10 @@ pecan.ma <- function(trait.data, prior.distns,
## check for excess missing data

if (all(is.na(data[["obs.prec"]]))) {
if (verbose) {
writeLines("NO ERROR STATS PROVIDED, DROPPING RANDOM EFFECTS")
}
data$site <- rep(1, nrow(data))
data$trt <- rep(0, nrow(data))
PEcAn.logger::logger.warn("NO ERROR STATS PROVIDED\n Check meta-analysis Model Convergence",
"and consider turning off Random Effects by",
"setting <random.effects>FALSE</random.effects>",
"in your pecan.xml settings file ")
}

if (!random) {
Expand Down