Fix several warnings #364
Merged
Fix several warnings #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING py.warnings:_warnings.py:37 WARNING: Passing `palette` without assigning `hue` is deprecated and will be removed in v0.14.0. Assign the `x` variable to `hue` and set `legend=False` for the same effect.
WARNING py.warnings:_warnings.py:37 WARNING: `rcond` parameter will change to the default of machine precision times ``max(M, N)`` where M and N are the input matrix dimensions. To use the future default and silence this warning we advise to pass `rcond=None`, to keep using the old, explicitly pass `rcond=-1`.
This change will raise an error in Nilearn 0.15, but that will make it easier to detect and fix. WARNING py.warnings:_warnings.py:37 WARNING: Applying "mask_img" before signal extraction may result in empty region signals in the output. These are currently kept. Starting from version 0.13, the default behavior will be changed to remove them by setting "keep_masked_labels=False". "keep_masked_labels" parameter will be removed in version 0.15.
/src/aslprep/aslprep/tests/test_cli.py:7: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html from pkg_resources import resource_filename as pkgrf
effigies
reviewed
Dec 8, 2023
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
reviewed
Dec 8, 2023
|
|
||
| # NOTE: Modified for aslprep's purposes | ||
| aslprep_spec = loads(Path(pkgrf("aslprep", "data/aslprep_bids_config.json")).read_text()) | ||
| aslprep_spec = loads(load_data.readable("aslprep_bids_config.json").read_text()) |
There was a problem hiding this comment.
👍 I would pretty much only use readable() in the form load_data.readable(...).read_<text|bytes>(), as otherwise you need to check that whoever you're passing it to is only going to use read_text() or read_bytes().
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
https://www.nipreps.org/niworkflows/master/api/niworkflows.data.html If you add |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 78.81% 79.09% +0.28%
==========================================
Files 39 39
Lines 4149 4148 -1
Branches 600 600
==========================================
+ Hits 3270 3281 +11
+ Misses 685 673 -12
Partials 194 194 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes none, but works on #344.
Changes proposed in this pull request
pkg_resourceswithaslprep.data.load.rcondtonumpy.linalg.lstsqcalls.huein seaborn calls.keep_masked_labelstoTrueinNiftiLabelsMaskercalls.