Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several warnings #364

Merged
merged 11 commits into from
Dec 8, 2023
Merged

Fix several warnings #364

merged 11 commits into from
Dec 8, 2023

Commits on Dec 8, 2023

  1. Address seaborn warning. 

    WARNING  py.warnings:_warnings.py:37 WARNING: Passing `palette` without assigning `hue` is deprecated and will be removed in v0.14.0. Assign the `x` variable to `hue` and set `legend=False` for the same effect.
    @tsalo
    tsalo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    7cea8c2 View commit details
    Browse the repository at this point in the history

  2. Address numpy.linalg.lstsq warning. 

    WARNING  py.warnings:_warnings.py:37 WARNING: `rcond` parameter will change to the default of machine precision times ``max(M, N)`` where M and N are the input matrix dimensions.
To use the future default and silence this warning we advise to pass `rcond=None`, to keep using the old, explicitly pass `rcond=-1`.
    @tsalo
    tsalo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ad3d428 View commit details
    Browse the repository at this point in the history

  3. Address NiftiLabelsMasker warning. 

    This change will raise an error in Nilearn 0.15, but that will make it easier to detect and fix.

WARNING  py.warnings:_warnings.py:37 WARNING: Applying "mask_img" before signal extraction may result in empty region signals in the output. These are currently kept. Starting from version 0.13, the default behavior will be changed to remove them by setting "keep_masked_labels=False". "keep_masked_labels" parameter will be removed in version 0.15.
    @tsalo
    tsalo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    513099b View commit details
    Browse the repository at this point in the history

  4. Drop pkg_resources. 

    /src/aslprep/aslprep/tests/test_cli.py:7: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    from pkg_resources import resource_filename as pkgrf
    @tsalo
    tsalo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ff33f52 View commit details
    Browse the repository at this point in the history

  5. Maybe fix.

    @tsalo
    tsalo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f1fb3c8 View commit details
    Browse the repository at this point in the history

  6. Update aslprep/cli/workflow.py 

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @tsalo @effigies
    tsalo and effigies committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    c27fb33 View commit details
    Browse the repository at this point in the history

  7. readable() produces Paths.

    @tsalo
    tsalo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    0dc5684 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @tsalo @effigies
    tsalo and effigies committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    81b8bd1 View commit details
    Browse the repository at this point in the history

  9. Add data module to API docs.

    @tsalo
    tsalo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f1cd4b3 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'fix-warnings' of https://github.com/tsalo/aslprep into … 

    …fix-warnings
    @tsalo
    tsalo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    d4b4559 View commit details
    Browse the repository at this point in the history

  11. Address API formatting issues.

    @tsalo
    tsalo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f1431c0 View commit details
    Browse the repository at this point in the history