Add fixture to skip test if jax is not present #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trbromley
added
the
review-ready 👌
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1066 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 153 153
Lines 11579 11579
=======================================
Hits 11318 11318
Misses 261 261 ☔ View full report in Codecov by Sentry. |
Comment on lines
+143
to
+147
| @pytest.fixture | ||
| def skip_if_no_jax_support(): | ||
| pytest.importorskip("jax") | ||
|
|
||
|
|
There was a problem hiding this comment.
I like that this is simpler, but should we instead match the import pattern used for Torch and TF?
There was a problem hiding this comment.
The above were written when I did not know of the existence of importorskip. I think this is simpler, and happy for the above to be rewritten to match.
chaserileyroberts
approved these changes
Feb 8, 2021
josh146
added a commit
that referenced
this pull request
Feb 12, 2021
Co-authored-by: Josh Izaac <josh146@gmail.com>
josh146
added a commit
that referenced
this pull request
Feb 12, 2021
* PR 1082 * PR 1072 * Update vqe.py (#1077) update `genearate_hamiltonian` refs * PR 1074 * Add jax skip (#1066) Co-authored-by: Josh Izaac <josh146@gmail.com> * update changelog * update version number * Apply suggestions from code review Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: antalszava <antalszava@gmail.com> Co-authored-by: antalszava <antalszava@gmail.com> Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
josh146
added a commit
that referenced
this pull request
Feb 12, 2021
* PR 1082 * PR 1072 * Update vqe.py (#1077) update `genearate_hamiltonian` refs * PR 1074 * Add jax skip (#1066) Co-authored-by: Josh Izaac <josh146@gmail.com> * update changelog * update version number * Update .github/CHANGELOG.md Co-authored-by: antalszava <antalszava@gmail.com> Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some tests were failing locally for me (without
jaxinstalled). I should installjax, but in case anyone else hasn't got it installed, this PR will make sure their tests don't fail.