V0.14.1 bump #1083
Merged
V0.14.1 bump #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update `genearate_hamiltonian` refs
Co-authored-by: Josh Izaac <josh146@gmail.com>
trbromley
reviewed
Feb 12, 2021
trbromley
reviewed
Feb 12, 2021
| @@ -865,6 +884,7 @@ def qfunc_decorator(func): | |||
| interface=interface, | |||
| diff_method=diff_method, | |||
| mutable=mutable, | |||
| max_expansion=max_expansion, | |||
There was a problem hiding this comment.
I know this has already been code reviewed, but for my understanding - we have added the max_expansion attribute but have we implemented the effects of changing max_expansion?
There was a problem hiding this comment.
Yep! The change is on line 781, max_expansion=10.
trbromley
approved these changes
Feb 12, 2021
antalszava
approved these changes
Feb 12, 2021
Comment on lines
+489
to
+491
| if all(c == 0 for c in coeffs) or not coeffs: | ||
| self.cost_fn = lambda *args, **kwargs: np.array(0) | ||
| return |
There was a problem hiding this comment.
Thank you for relocating this! 🚀
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: antalszava <antalszava@gmail.com>
Codecov Report
@@ Coverage Diff @@
## v0.14.1-bugfix #1083 +/- ##
===============================================
Coverage 97.75% 97.75%
===============================================
Files 153 153
Lines 11517 11530 +13
===============================================
+ Hits 11258 11271 +13
Misses 259 259
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the bugfix PRs in the v0.14.1 milestone into a holding branch for the v0.14.1 release.
Bumps the version number
Updates the changelog