legacy device: check if object is measurement before checking stopping_condition #5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmysilv
commented
Jan 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5071 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 394 394
Lines 35670 35428 -242
==========================================
- Hits 35554 35310 -244
- Misses 116 118 +2 ☔ View full report in Codecov by Sentry. |
albi3ro
approved these changes
Jan 16, 2024
timmysilv
added a commit
that referenced
this pull request
Jan 17, 2024
Same as #5071 but in other places. I'm a little worried that maybe we shouldn't deprecate `MeasurementProcess.name` at all... seems like we kinda depend on it? My first thought was to just make them more correct (eg. "State", "Probs"), but I don't think any devices have those saved in their `dev.observables` so I suppose this might still be the best way forward
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
…g_condition (#5071) **Context:** Many plugins are failing because of the deprecation of `MeasurementProcess.name` (#5047). The old device API checks if an object meets the stopping requirement _or_ if it's a measurement (in that order). Due to this ordering, we reference `mp.name` which is now deprecated. **Description of the Change:** Swap the order of conditions in `_local_tape_expand` to avoid hitting this deprecation warning **Benefits:** Plugins will work again! **Possible Drawbacks:** N/A
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
Same as #5071 but in other places. I'm a little worried that maybe we shouldn't deprecate `MeasurementProcess.name` at all... seems like we kinda depend on it? My first thought was to just make them more correct (eg. "State", "Probs"), but I don't think any devices have those saved in their `dev.observables` so I suppose this might still be the best way forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Many plugins are failing because of the deprecation of
MeasurementProcess.name(#5047). The old device API checks if an object meets the stopping requirement or if it's a measurement (in that order). Due to this ordering, we referencemp.namewhich is now deprecated.Description of the Change:
Swap the order of conditions in
_local_tape_expandto avoid hitting this deprecation warningBenefits:
Plugins will work again!
Possible Drawbacks:
N/A