update more spots that use MP.name

[timmysilv]

Same as #5071 but in other places.

I'm a little worried that maybe we shouldn't deprecate MeasurementProcess.name at all... seems like we kinda depend on it? My first thought was to just make them more correct (eg. "State", "Probs"), but I don't think any devices have those saved in their dev.observables so I suppose this might still be the best way forward

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c01cb4b) 99.67% compared to head (a1d31e1) 99.67%.
Report is 24 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5076      +/-   ##
==========================================
- Coverage   99.67%   99.67%   -0.01%     
==========================================
  Files         394      394              
  Lines       35670    35462     -208     
==========================================
- Hits        35554    35346     -208     
  Misses        116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[josh146]

@timmysilv I could provide some context if needed since (I think??) I originally added this. The original motivation was mostly repr/printing for end users (so that circuits would show as qml.expval(qml.PauliZ) when displayed etc.)

[timmysilv]

@josh146 we're deprecating MeasurementProcess.name and MeasurementProcess.data, because they were always "Identity" and [], respectively (see file at time of adding). Every time we checked MP.name, it was "Identity", even today:

>>> qml.state().name
/Users/matthews/src/github.com/PennyLaneAI/pennylane/pennylane/measurements/measurements.py:196: PennyLaneDeprecationWarning: MeasurementProcess.name is deprecated, and will be removed in an upcoming release. To get the name of an observable from a measurement, use MeasurementProcess.obs.name instead
  warn(
'Identity'

that said, Device clearly does check it and handle it, even though it was always "Identity". While I hoped this wouldn't affect things, it still can sometimes as we're seeing.

[josh146]

got it, thanks @timmysilv!