Make ApproxTimeEvolution compatible with op math
#5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o linearcombination
…o linearcombination
…into approx-time-evolution-opmath
albi3ro
added a commit
that referenced
this pull request
Mar 14, 2024
In PR #5362 , I wanted to make `ApproxTimeEvolution` depend on the `pauli_rep` of the provided operator. Unfortunately, we never added to `Hamiltonian` because we didn't see the point in improving `Hamiltonian`. But not we are in the place where it needs to have similar behaviour to its replacement. So let's just add the `pauli_rep` property in. [sc-58834] --------- Co-authored-by: Korbinian Kottmann <43949391+Qottmann@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5362 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 398 398
Lines 37021 36721 -300
==========================================
- Hits 36891 36590 -301
- Misses 130 131 +1 ☔ View full report in Codecov by Sentry. |
lillian542
approved these changes
Mar 14, 2024
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
Qottmann
approved these changes
Mar 15, 2024
Qottmann
added a commit
that referenced
this pull request
Mar 15, 2024
`Sum.sparse_matrix()` uses the pauli rep to compute the sparse matrix, which has a different default wire order which causes a failure. The update is in a subfunction of `RiemannianGradientOptimizer` to use explicit wire_order argument of the tape. - [x] `tests/optimize` pass except for one mentioned below - [x] `tests/optimize/test_qng.py::TestOptimize::test_step_and_cost_autograd_with_gen_hamiltonian` deferred to [this story](https://app.shortcut.com/xanaduai/story/58893/update-tests-tests-optimize-test-qng-py-testoptimize-test-step-and-cost-autograd-with-gen-hamiltonian) builds on top of #5362 [sc-58399] --------- Co-authored-by: albi3ro <chrissie.c.l@gmail.com> Co-authored-by: Christina Lee <christina@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-58598] [sc-58407]
Context:
ApproxTimeEvolutiontests are failing when used with new operator arithmeticDescription of the Change:
Update
ApproxTimeEvolutionto rely on the pauli rep.Benefits:
Possible Drawbacks:
Related GitHub Issues: