Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Hamiltonian.pauli_rep #5377

Merged
merged 13 commits into from
Mar 14, 2024
Merged

Define Hamiltonian.pauli_rep #5377

merged 13 commits into from
Mar 14, 2024

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Mar 13, 2024

In PR #5362 , I wanted to make ApproxTimeEvolution depend on the pauli_rep of the provided operator. Unfortunately, we never added to Hamiltonian because we didn't see the point in improving Hamiltonian. But not we are in the place where it needs to have similar behaviour to its replacement. So let's just add the pauli_rep property in.

[sc-58834]

@albi3ro albi3ro marked this pull request as ready for review March 13, 2024 18:21
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a small change, why didn't we just do it before 😅

Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looking good!

@albi3ro albi3ro disabled auto-merge March 13, 2024 18:42
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (59b2078) to head (4e58d15).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5377    +/-   ##
========================================
  Coverage   99.64%   99.64%            
========================================
  Files         401      398     -3     
  Lines       37264    36734   -530     
========================================
- Hits        37131    36603   -528     
+ Misses        133      131     -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Qottmann Qottmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 👌 thanks @albi3ro

pennylane/pauli/utils.py Outdated Show resolved Hide resolved
tests/transforms/test_sign_expand.py Outdated Show resolved Hide resolved
@Qottmann
Copy link
Contributor

Just noticed we lost some coverage in pennylane/pauli/conversion.py 😬

pennylane/pauli/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Qottmann Qottmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just re-approving after some additional changes 👍

@albi3ro albi3ro merged commit 8f5bf9b into master Mar 14, 2024
40 checks passed
@albi3ro albi3ro deleted the hamiltonian-pauil-rep branch March 14, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants