-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Hamiltonian.pauli_rep
#5377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a small change, why didn't we just do it before 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, looking good!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5377 +/- ##
========================================
Coverage 99.64% 99.64%
========================================
Files 401 398 -3
Lines 37264 36734 -530
========================================
- Hits 37131 36603 -528
+ Misses 133 131 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 👌 thanks @albi3ro
Just noticed we lost some coverage in |
…I/pennylane into hamiltonian-pauil-rep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just re-approving after some additional changes 👍
In PR #5362 , I wanted to make
ApproxTimeEvolution
depend on thepauli_rep
of the provided operator. Unfortunately, we never added toHamiltonian
because we didn't see the point in improvingHamiltonian
. But not we are in the place where it needs to have similar behaviour to its replacement. So let's just add thepauli_rep
property in.[sc-58834]