-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
As it turns out, PERF_RECORD_READ events are only emitted when the inherit and inherit_stat flags are set. inherit is incompatible with READ_FORMAT_GROUP so PERF_RECORD_READ will never be emitted with a group format. This PR takes advantage of that to simplify some things and I've also gone and rethought how `ReadGroup` and `ReadValue` should be used. - Sample now always contains a ReadGroup and converts if the source read_format is only for a single value. - Read now only contains a ReadValue since it is not possible to create a Read record when GROUP is set in read_format - ReadGroup can now be converted into ReadValue via TryFrom - ReadValue can now be converted into ReadGroup via From - ReadData has been deleted since the conversions take its place
- Loading branch information
1 parent
8c665e9
commit aabc090
Showing
4 changed files
with
113 additions
and
95 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters