Simplify how Read and read_value types are exposed
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it turns out, PERF_RECORD_READ events are only emitted when the inherit and inherit_stat flags are set. inherit is incompatible with READ_FORMAT_GROUP so PERF_RECORD_READ will never be emitted with a group format. This doesn't mean we can delete all the code around reading group data because they are still used within PERF_RECORD_SAMPLE.
- Sample now always contains a ReadGroup and converts if the source read_format is only for a single value. - Read now only contains a ReadValue since it is not possible to create a Read record when GROUP is set in read_format - ReadGroup can now be converted into ReadValue via TryFrom - ReadValue can now be converted into ReadGroup via From - ReadData has been deleted since the conversions take its place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, PERF_RECORD_READ events are only emitted when the inherit and inherit_stat flags are set. inherit is incompatible with READ_FORMAT_GROUP so PERF_RECORD_READ will never be emitted with a group format. This PR takes advantage of that to simplify some things and I've also gone and rethought how
ReadGroupandReadValueshould be used.