Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify how Read and read_value types are exposed #19

Merged
merged 3 commits into from
May 14, 2023
Merged

Simplify how Read and read_value types are exposed #19

merged 3 commits into from
May 14, 2023

Commits on May 14, 2023

  1. Change Read record to only support non-group reads 

    As it turns out, PERF_RECORD_READ events are only emitted when the
inherit and inherit_stat flags are set. inherit is incompatible with
READ_FORMAT_GROUP so PERF_RECORD_READ will never be emitted with a group
format.

This doesn't mean we can delete all the code around reading group data
because they are still used within PERF_RECORD_SAMPLE.
    @Phantomical
    Phantomical committed May 14, 2023
    Configuration menu
    Copy the full SHA
    25e1220 View commit details
    Browse the repository at this point in the history

  2. Document ReadValue

    @Phantomical
    Phantomical committed May 14, 2023
    Configuration menu
    Copy the full SHA
    70a5b0f View commit details
    Browse the repository at this point in the history

  3. Rework how reading read_format values works 

    - Sample now always contains a ReadGroup and converts if the source
  read_format is only for a single value.
- Read now only contains a ReadValue since it is not possible to create
  a Read record when GROUP is set in read_format
- ReadGroup can now be converted into ReadValue via TryFrom
- ReadValue can now be converted into ReadGroup via From
- ReadData has been deleted since the conversions take its place
    @Phantomical
    Phantomical committed May 14, 2023
    Configuration menu
    Copy the full SHA
    623ab38 View commit details
    Browse the repository at this point in the history