Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use utf8mb4 instead of utf8 #18

Merged
merged 1 commit into from
Sep 2, 2022
Merged

use utf8mb4 instead of utf8 #18

merged 1 commit into from
Sep 2, 2022

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Sep 2, 2022

DM use go-sqlsmith to generate ddl. However TiDB doesn't support utf8mb3 pingcap/tidb#26226, so use utf8mb4 instead

lance6716
lance6716 approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also check if the collation should be set explicitly

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 2, 2022

/merge

@purelind purelind merged commit 590164e into PingCAP-QE:master Sep 2, 2022
@GMHDBJD GMHDBJD mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GMHDBJD @lance6716 @purelind