Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chaos: fix utf8mb3 and utf8mb4_0900_ai_ci for chaos test #6960

Merged
merged 12 commits into from
Sep 8, 2022

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Sep 2, 2022

What problem does this PR solve?

Issue Number: ref #4159

What is changed and how it works?

Release note

None

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #6960 (a01fa93) into master (9398176) will increase coverage by 0.0337%.
The diff coverage is 58.4816%.

❗ Current head a01fa93 differs from pull request most recent head c88aa9a. Consider uploading reports for the commit c88aa9a to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 67.2470% <57.8048%> (+0.0510%) ⬆️
dm 51.9098% <25.0000%> (-0.0382%) ⬇️
engine 62.3559% <60.4316%> (+0.0937%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6960        +/-   ##
================================================
+ Coverage   59.8253%   59.8591%   +0.0337%     
================================================
  Files           791        790         -1     
  Lines         90221      90561       +340     
================================================
+ Hits          53975      54209       +234     
- Misses        31498      31592        +94     
- Partials       4748       4760        +12     

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 2, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2022
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2022
@GMHDBJD GMHDBJD added component/test Unit tests and integration tests component. area/dm Issues or PRs related to DM. labels Sep 6, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 6, 2022

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 6, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb64a8e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 7, 2022

/merge

@lance6716
Copy link
Contributor

/run-verify
/run-dm-integration-test

@ti-chi-bot
Copy link
Member

@GMHDBJD: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 5f98426 into pingcap:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. component/test Unit tests and integration tests component. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants