Voting module test refactor #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Permission_manager command added * newDelegate fix * Issuer account is read from ./privKeyLocal * CLI Permission Manager update
* Migrated from npm to yarn * Updated instructions * Added yarn to CLI * Added package-lock.json to gitignore
* branches coverage reached to 85 % * increase coverage of transferManagers * improve the coverage of token * introduced withdrawERC20() in the changelog * fix * minor fixes
* Truffle config rename * Windows support added * Windows test accounts fixed * Added coverage support on windows * patch for solcover solcover * coverage test command changed * Updated coverage script * updated gitignore * Update README.md
|
@comeonbuddy I feel you should be doing this on the open PR we have for voting instead of opening a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
refactor test files to adopt the new test standards
What is the current behavior?
use the old test standards
What is the new behavior?
adopt the new test standards
Does this PR introduce a breaking change?
no
Any Other information: