Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-exploration): convert funnel properties correlation table #14992

Conversation

thmsobrmlr
Copy link
Contributor

Problem

Funnel correlations need to be converted to data exploration for feature parity.

Changes

This PR

  • converts the funnel properties correlation table

How did you test this code?

Manual testing

@thmsobrmlr thmsobrmlr changed the base branch from master to data-exploration-funnel-correlation-6 April 5, 2023 17:42
@thmsobrmlr thmsobrmlr changed the title Data exploration funnel correlation 7 feat(data-exploration): convert funnel properties correlation table Apr 5, 2023
@thmsobrmlr thmsobrmlr marked this pull request as ready for review April 5, 2023 18:16
@thmsobrmlr thmsobrmlr requested a review from a team April 5, 2023 18:16
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is up with the cypress preparation step in CI, but code looks good 👍

@thmsobrmlr thmsobrmlr merged commit eb9f5b7 into data-exploration-funnel-correlation-6 Apr 6, 2023
@thmsobrmlr thmsobrmlr deleted the data-exploration-funnel-correlation-7 branch April 6, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants