feat(data-exploration): convert funnel correlation to data exploration #14963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
force-pushed
the
data-exploration-funnel-correlation-1
branch
from
e34b1d8
to
90df0a0
Compare
thmsobrmlr
changed the title
|
I don't know why GitHub thinks this should need Django tests. |
34 tasks
mariusandra
approved these changes
Apr 6, 2023
thmsobrmlr
changed the title
Twixes
approved these changes
Apr 6, 2023
| @@ -30,12 +30,12 @@ import { | |||
| import { PathCanvasLabel } from 'scenes/paths/PathsLabel' | |||
| import { InsightLegend } from 'lib/components/InsightLegend/InsightLegend' | |||
| import { InsightLegendButtonDataExploration } from 'lib/components/InsightLegend/InsightLegendButton' | |||
| // import { FunnelCorrelation } from './views/Funnels/FunnelCorrelation' | |||
| // import { AlertMessage } from 'lib/lemon-ui/AlertMessage' | |||
There was a problem hiding this comment.
This seems unnecessary too?
There was a problem hiding this comment.
That'll go in again when I implement the isUsingSessionAnalysis flag.
fuziontech
added a commit
that referenced
this pull request
Apr 7, 2023
* master: fix(flags): don't enclose in overall transaction so we get latest reads (#15003) fix(tests): make getEventsByPerson output stable to avoid flakes (#15009) feat(data-exploration): convert funnel correlation to data exploration (#14963) fix: Set hobby deployments to 'latest' by default (#14956) feat(hogql): lambdas (#14987) feat(hogql): arrays and tuples (#14986) fix(funnel): always use total step count for funnel chart label (#14993)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: Conversion of Funnel Correlation to Data Exploration
Conversion of funnel correlation to data exploration is a wrap!
I've stacked the relevant PRs on top of each other for easier review-ability, but for clicking around feel free to go straight to the last one #14992.
Here's a brief summary of the PRs:
In broad terms, I've split out the correlations related code from
funnelLogicinto separate logics with a clear purpose:funnelCorrelationLogic: event and event property correlationfunnelPropertyCorrelationLogic: property correlationfunnelCorrelationDetailsLogic: the details popupfunnelCorrelationFeedbackLogic: the feedback formfunnelCorrelationUsageLogic: usage tracking with posthog.jsThe components and logics then disambiguate between data exploration and legacy mode for everything that is pulled in from the funnel.
I'm going to give this one more review before merging in myself, but the whole thing is ready for review now.
Problem
In order to convert the funnel correlation work to data exploration, the
<FunnelCorrelation />component needed a bit of preparation. I'm going to stack other PRs converting the funnel correlations on top.Changes
This PR:
How did you test this code?
Manual testing