Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(recordings): use cooperative-sticky rebalance strategy #15260

Merged

Conversation

hazzadous
Copy link
Contributor

@hazzadous hazzadous commented Apr 26, 2023

Reverts #15211 with was a revert of this change!

I think we were caught off guard by a very hot partition the last time this went out,
which caused some havoc. We also have KEDA scaling being deployed so hopefully
that should give us some protection against hot partitions. We'll see. Let's (test in
production)™️ 🚀

Update: Oh shoot, conflicts! Sorry for the premature review request!

revert-15211-revert-15197-chore/use-cooperative-rebalance

I needed to update a few references to node-rdkafka-acosom as well.
@hazzadous hazzadous enabled auto-merge (squash) April 26, 2023 12:48
@hazzadous hazzadous merged commit 96fe16f into master Apr 26, 2023
@hazzadous hazzadous deleted the revert-15211-revert-15197-chore/use-cooperative-rebalance branch April 26, 2023 13:09
fuziontech added a commit that referenced this pull request Apr 27, 2023
* master: (37 commits)
  fix: fix sprint planning issue template (#15271)
  fix: player skip buttons only ever showed right (#15269)
  chore: bump vm2 due to CVE (#15268)
  fix(person-query): don't query persons twice if we don't need to (#15265)
  fix(ch): stop running delete jobs while clickhouse is on an older version (#15239)
  chore(recordings): use cooperative-sticky rebalance strategy (#15260)
  fix: SESSION_RECORDING_BLOB_PROCESSING_TEAMS config handling (#15247)
  fix(flags): Some UX inconsistencies (#15255)
  fix: Recording share button (#15256)
  chore(deps): Update posthog-js to 1.54.0 (#15257)
  style(3000): Support keyboard navigation in sidebar (#15237)
  feat: Add support for opening bug report via URL (#15251)
  feat: Hedgebar (#14934)
  Fixed undefined default for window select (#15249)
  fix(data-exploration): prevent leave confirmation safeguard (#15250)
  chore: remove readonly setting defaults for hogql (#15246)
  feat(hogql): refactor macros and asterisks into "resolver" (#15175)
  feat(hogql): swap out toDateTime function (#15226)
  fix(insight-timeout-state): centralize query ID (#15240)
  Fix/forgot ingestion fixes (#15238)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants