Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for opening bug report via URL #15251

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Apr 26, 2023

Problem

Adds support for one of the things mentioned here

Linking people to the modal to submit a bug report would be great

Changes

  • Adds routing logic to allow URLs like
    • /home#supportModal
    • /home#supportModal=bug:session_replay
  • Also fixes a typo

@mariusandra To solve the redirect issue I added a helper function to the scene redirects. Feel free to suggest a better alternative if you have one

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Just manually

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does what it says on the tin 👨‍🍳 👌

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • firefox: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite enabled auto-merge (squash) April 26, 2023 08:10
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • firefox: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite merged commit 503b15c into master Apr 26, 2023
@benjackwhite benjackwhite deleted the report-a-bug-modal branch April 26, 2023 08:30
@@ -39,18 +40,19 @@ export const TargetAreaToName = {
experiments: 'Experiments',
feature_flags: 'Feature Flags',
login: 'Login / Sign up / Invites',
session_reply: 'Session Replay',
session_replay: 'Session Replay',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuziontech added a commit that referenced this pull request Apr 27, 2023
* master: (37 commits)
  fix: fix sprint planning issue template (#15271)
  fix: player skip buttons only ever showed right (#15269)
  chore: bump vm2 due to CVE (#15268)
  fix(person-query): don't query persons twice if we don't need to (#15265)
  fix(ch): stop running delete jobs while clickhouse is on an older version (#15239)
  chore(recordings): use cooperative-sticky rebalance strategy (#15260)
  fix: SESSION_RECORDING_BLOB_PROCESSING_TEAMS config handling (#15247)
  fix(flags): Some UX inconsistencies (#15255)
  fix: Recording share button (#15256)
  chore(deps): Update posthog-js to 1.54.0 (#15257)
  style(3000): Support keyboard navigation in sidebar (#15237)
  feat: Add support for opening bug report via URL (#15251)
  feat: Hedgebar (#14934)
  Fixed undefined default for window select (#15249)
  fix(data-exploration): prevent leave confirmation safeguard (#15250)
  chore: remove readonly setting defaults for hogql (#15246)
  feat(hogql): refactor macros and asterisks into "resolver" (#15175)
  feat(hogql): swap out toDateTime function (#15226)
  fix(insight-timeout-state): centralize query ID (#15240)
  Fix/forgot ingestion fixes (#15238)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants