Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth-4.9 pdnsutil check-zone: make LUA records optional #14711

Open
wants to merge 1 commit into
base: rel/auth-4.9.x
Choose a base branch
from
Open

auth-4.9 pdnsutil check-zone: make LUA records optional #14711

wants to merge 1 commit into from
+2 −0

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Sep 25, 2024

Short description

backport of #14261

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@swegener @Habbie
pdnsutil check-zone: make LUA records optional
cdccfeb 
Merge PowerDNS#14011 added checking for LUA records to checkZone(), but LUA
records depend on --enable-lua-records and the change causes a build
error without.

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
(cherry picked from commit 175b5e6)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11032493478

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.03%) to 63.165%
Files with Coverage Reduction New Missed Lines %
modules/lmdbbackend/lmdbbackend.cc 2 73.57%
pdns/auth-secondarycommunicator.cc 2 64.65%
pdns/tsigverifier.cc 3 77.22%
pdns/rcpgenerator.cc 3 89.77%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
Totals Coverage Status
Change from base Build 11032388645: 0.03%
Covered Lines: 41776
Relevant Lines: 59383
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeha zeha zeha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Habbie @coveralls @zeha @swegener