Release 5.1.3

[kpodemski]

Questions	Answers
Description?	New version
Type?	new feature
BC breaks?	no
Deprecations?	no
Fixed ticket?	n/a
How to test?	Exploratory tests of the module

[leemyongpakvn]

@MhiriFaten I see you used gh pr checkout 565 in Checked with Chrome screencast, but don't know what you did prior. Please provide more information about how you made a fresh install before that command (eg: uninstall with files deleted options then install v5.1.2 in BO, or rm -rf then git clone in Terminal).

[kpodemski]

@leemyongpakvn I'm starting to think that it might be related to the shop being in the directory called x.y.z

[leemyongpakvn]

@kpodemski Maybe, we need a QA member who can test this PR in a simpler directory.
Beside that, I doubt gh pr checkout 565 is not the correct way to test this PR:

1. When I tried unsintall the module with ✅ Optional: delete module folder after uninstall, reinstall v5.1.2 in BO, then cd modules/blockreassurance & gh pr checkout 565 in Terminal, it breaks the whole site.
2. All files changed of this PR were already merged to dev branch, so git clone https://github.com/PrestaShop/blockreassurance.git is the best way to make a fresh install.

@florine2623 I wonder if QA team has a standard procedure to test a Release PR like this one ❓

[kpodemski]

@leemyongpakvn there is a process to test such releases, and gh pr checkout 565 should definitely not break your site, maybe you forgot to run composer install --no-dev?

We have to test it in the subdirectory. I tested it using multistore and virtual URI and it worked fine, but I didn't test it in the subdirectory.

[leemyongpakvn]

@kpodemski Maybe I ran gh pr checkout 565 in modules directory and it broke the whole site in the previous test :(
Case 1. If you install the module via Back-Office, it does not contain git file, so gh pr checkout 565 will returns error

could not determine base repo: fatal: not a git repository (or any of the parent directories): .git
/usr/bin/git: exit status 128

Case 2. If you do a fresh install with git clone https://github.com/PrestaShop/blockreassurance.git then 'gh pr checkout 565' will returns something like this

Already on 'dev'
Your branch is up to date with 'origin/dev'.
Already up to date.

Back to MhiriFaten's Checked with Chrome screencast. In fact, she ran git branch between 0:01 to 0:02 and got dev *pr-565. I got just * dev when running git branch on my side. So I still want to know how QA make a fresh install of a Release PR 🙏

[MhiriFaten]

@leemyongpakvn I meant that it can't be a cache issue as long as I clear the cache and the PR was added on a fresh installed shop.

[leemyongpakvn]

@MhiriFaten OK. Then you can try Krystian's suggestion: using a simpler directory :)

[matks]

I just tried to install blockreassurance v5.1.3 inside a subfolder named 1.2.3 and it works very well for me, I cannot reproduce the issues encountered by QA team. I will suggest a pair testing.

[florine2623]

Hello all,

On my end, I can reproduce any of the issues mentioned by @MhiriFaten and @aniszr 😅

Here are the screenrecords:

About this comment
#565 (review)

PS 8.0.5 ✅

Screen.Recording.2023-09-29.at.09.53.50.mov

PS 1.7.8.10 ✅

Screen.Recording.2023-09-29.at.10.21.04.mov

About this comment
#565 (review)

PS 8.1.2 ✅

Screen.Recording.2023-09-29.at.10.27.03.mov

So it is QA ✅
Thanks all ^^

[matks]

Thank you @florine2623 !

I strongly suggest we do merge this PR only on Monday, I would feel safer 😊

[leemyongpakvn]

Thanks @florine2623, @kpodemski and @matks