Fix upgrade module to v4

[jf-viguier]

Questions	Answers
Description?	Add required hooks and configuration values for v4 upgrade
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#23218
How to test?	see issue

It seems that the upgrade file is not launched at prestashop 1.7 upgrade in some cases. So I added a default commentsPerPage in paginate method

[jf-viguier]

thanks @Progi1984, can you add my 3 pr in this module to 4.2.2 version ?
This pr should fix this pr too #92
(in fact it's just a test to make)

[matthieu-rolland]

@kpodemski seems like your feedback has been dealt with 👍

[jf-viguier]

@kpodemski is it ok now ?

[kpodemski]

@jf-viguier great, thanks 👍

[hibatallahAouadni]

Hello @jf-viguier

I'm really sorry but it seems I have an issue with installing the productcomment module v3.6.1 on 1.6.1.20

I tried many times but in vain 😖
Ping @PrestaShop/qa-functional could someone please test this PR cause I can't.

Thanks in advance 🙏

[khouloudbelguith]

Hi @jf-viguier,

I followed these steps:

1. Install PrestaShop 1.6.1.24

2. Install module product comment 3.6.0 from GitHub

3. Add a comment with guest and customer

4. Approve those comments

5. Upgrade PrestaShop to PS1.7.7.5 (I found that the productcomment module is upgraded to v4.2.1)

6. I Upgraded manually the product comment module to this PR (v4.2.2)

7. Go to FO
   

8. View a product with a comment

9. See error => No comment is displayed
   

Thanks to check and feedback.

[jf-viguier]

@khouloudbelguith have you cleared the ps cache ?

[sarahdib]

@jf-viguier I have the same bug as @khouloudbelguith and all cache are cleared.

[hibatallahAouadni]

Ping @PrestaShop/prestashop-core-developers is there any one have an idea about how to test this PR 🙏
I suggest these steps, so can someone check if these are correcte:

1. Install PS 1.6.1.24
2. Install Product comments with these cmds:

• cd /your-shop/modules/
• git clone https://github.com/PrestaShop/productcomments.git
• cd productcomments
• git checkout tags/v3.6.0 -b v3.6.0
• BO>Module Catalog>Click on install of Product Comments

3. Create 6 comments with guests and Customers
4. Approve all
5. git fetch origin pull/107/head:pr-107 && git checkout pr-107 && git reset --hard && git clean -fd && git rebase origin/dev && composer install
6. Upgrade the shop to 1.7.8.2
7. Check the comments in FO

Thanks in advance 🙏

[kpodemski]

@hibatallahAouadni

IMO it's a good scenario for tests 👍

[jf-viguier]

The productcomments is updated during pretashop upgrade from addons : so the code of this pr will not be launched, how to solve this @kpodemski ?

[kpodemski]

@jf-viguier hmm, you're right

I think we need to create a package for the module.

1. composer install
2. Make a .zip from the productcomments directory. And install this module after the upgrade.

@jf-viguier that should do it, right?

[jf-viguier]

@kpodemski I guess no, upgrade/install-4.0.0.php of my pr has to be launched. Prestashop upgrade will upgrade the module to the version 5.

[Progi1984]

Discussed with @hibatallahAouadni about the process, she will test with this process. Thanks to her.

[hibatallahAouadni]

Hello everyone,

Following my steps (mentioned above), I encounter first issue while upgrading:

Then, I give the access rights to the module and re-upgrade to 1.7.8.2, and it was a success:

As you can see in module manager, the PR is well installed:

Clicking on Configure, you could see the 6 created comments before upgrade:

But on FO, the block product comments is not displayed:

I checked the position of hooks and it seems good to me:

I check the table of product_comments, and it seems all good to me:

So, @jf-viguier you need to follow my steps to check and fix the issue (the block product comments is not displayed).
Please check and feedback.

Thanks!

[jf-viguier]

modules\productcomments\upgrade\install-4.0.0.php is well executed during test steps.

There are two issues with your steps @hibatallahAouadni

1. After prestashop upgrade, there are some missing hooks for the module (displayRightColumnProduct & displayFooterProduct):
   

2. my changes in modules\productcomments\src\Repository\ProductCommentRepository.php are deleted by prestashop upgrade, so you have to update it manually

There is still a javascript error to fix in modules\productcomments\views\templates\hook\product-additional-info-quickview.tpl (remove all script here) and then comments will whow up.

Please check @hibatallahAouadni

[jf-viguier]

I've just rebased my pr

[hibatallahAouadni]

Hello @jf-viguier

After adding this hook displayFooterProduct:

All comments are well displayed and the pagination works 💯

pr_107.mp4

LGTM, QA ✔️

Thanks for your hard working 🚀

[jf-viguier]

Thanks @hibatallahAouadni

[Progi1984]

Thanks @jf-viguier & @hibatallahAouadni (for the hard work QA on this PR).